Date: Thu, 23 Aug 2018 10:10:01 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Conrad Meyer <cem@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338214 - in head/sys: conf kern sys Message-ID: <c0590c80-6c92-dc00-f781-38506e81a46e@FreeBSD.org> In-Reply-To: <201808222219.w7MMJhpl049457@repo.freebsd.org> References: <201808222219.w7MMJhpl049457@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23/08/2018 01:19, Conrad Meyer wrote: > Author: cem > Date: Wed Aug 22 22:19:42 2018 > New Revision: 338214 > URL: https://svnweb.freebsd.org/changeset/base/338214 > > Log: > KASSERT: Make runtime optionality optional Thank you! > Add an option, KASSERT_PANIC_OPTIONAL, that allows runtime KASSERT() > behavior changes. When this option is not enabled, code that allows > KASSERTs to become optional is not enabled, and all violated assertions > cause termination. > > The runtime KASSERT behavior was added in r243980. > > One important distinction here is that panic has __dead2 > ("attribute((noreturn))"), while kassert_panic does not. Static analyzers > like Coverity understand __dead2. Without it, KASSERTs go misunderstood, > resulting in many false positives that result from violation of program > invariants. > > Reviewed by: jhb, jtl, np, vangyzen > Relnotes: yes > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D16835 -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c0590c80-6c92-dc00-f781-38506e81a46e>