From owner-dev-commits-src-all@freebsd.org Mon Aug 30 15:24:46 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E32E46586E8; Mon, 30 Aug 2021 15:24:46 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GyvJG5fNFz52j1; Mon, 30 Aug 2021 15:24:46 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f52.google.com with SMTP id n24so20369423ion.10; Mon, 30 Aug 2021 08:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/kbiN86vHAZDTI9uC90h7HsD9dZGGuLwmimit1fr/Iw=; b=aQh0ZbHWt1t3iWSweo1D+OKYkJl66DkEpAkZYdbT6flRIR13vK2qL74p8Y+QojutGe THJphf+3zJiazJ5+aVyVCR7xP5n5QnbwXwryqWrMsgzILGsD3KTwGVYymOmVyky/mW1F 3okPoi3wTbC3qUMRGKfR95mIAP8bMY27ISVas5z11MgR05mxYaW7h61xPvjbHbkQv+ez UnRcGMo3bBiQvAJXrrEPz9SZPMMF3dPXQ1zFQg4yXMu6L1VISomSwzJsTk92VdGtOBUW eRQySO52p8C+ehl8TzbxEsEgr/AeEEzNE9ttrNtEo7CosrBhJatP139dDhtyG0jvJtGs FEmg== X-Gm-Message-State: AOAM5339D1tywTR0NsEX6MLOaw4p31mfN9fiCTisV0LApx8ebvBPV1CF aKVp4BPF4YklO47TDRW/nEjdfP4mc52tZPApMDgGtVmfAok= X-Google-Smtp-Source: ABdhPJx/6VvhbG2iQfLyIU82PwSudqn4yyj1lTsdivVM/hf1aIoMvHMPhPYYjMMArnl2NS8hXa7MBVnviWjGUoVaQ64= X-Received: by 2002:a02:90d0:: with SMTP id c16mr20683367jag.106.1630337079217; Mon, 30 Aug 2021 08:24:39 -0700 (PDT) MIME-Version: 1.0 References: <202108301457.17UEvCRv008780@gitrepo.freebsd.org> In-Reply-To: <202108301457.17UEvCRv008780@gitrepo.freebsd.org> From: Ed Maste Date: Mon, 30 Aug 2021 11:24:24 -0400 Message-ID: Subject: Re: git: 4d0dc60f1401 - main - xinstall: fix invocation of llvm-strip To: Mitchell Horne Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4GyvJG5fNFz52j1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 15:24:47 -0000 On Mon, 30 Aug 2021 at 10:57, Mitchell Horne wrote: > > The branch main has been updated by mhorne: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02 > > commit 4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02 > Author: Mitchell Horne > AuthorDate: 2021-06-02 15:00:56 +0000 > Commit: Mitchell Horne > CommitDate: 2021-08-30 14:56:10 +0000 > > xinstall: fix invocation of llvm-strip > > When executing strip(1), '--' is passed as an argument to explicitly > terminate the getopt(3) loop. The option parsing in llvm-strip doesn't > support this however, so setting XSTRIPBIN=llvm-strip results in an > unsupported argument error. llvm-strip(1) is otherwise > commandline-compatible with FreeBSD's strip(1), so just use the > documented argument format that is common to both. GNU strip also handles --, so ideally we'd have llvm-strip also accept it. Given plans to switch to the LLVM version of various binutils (D31060) we should aim for as complete command-line compatibility as possible. I've added a note to this effect in D31060.