From owner-svn-src-all@freebsd.org Fri Dec 29 22:47:46 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80FC8EB460E; Fri, 29 Dec 2017 22:47:46 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FCED7F3FB; Fri, 29 Dec 2017 22:47:45 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f182.google.com with SMTP id 87so38204507ior.5; Fri, 29 Dec 2017 14:47:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=w8xy2B+g4D4KKQvvAI+TTkycVV5hX/ThhqUiUuEQ7vQ=; b=OZQfuDTSTJFOjUBUxftiruQib7hEpGti9YGUa0bb89sNCHYkzoJjgg5sPXFDFF8MjD BUsSBHAkla3NeKmdrhYzKao6K5KP/j8noSXtT7r6gqRVW4f/XGHLMT8JbWMbI3OwvRFv oSA35dicu8M2Ty4s3kgVGML4bABtjFq9SNadXTrEoFwZd7RMLQLOt0XPURbpMfueETYE ts78J+M5j0FlcvC8QGBTrl8Tx8TqOkwNAzoodDkHCzEd/5qdBkEaqLB6z7Y6FJqY78lI a1ufJnrTiMfxkcr97MPnXYGfqhI5nMrC8Gfr6D32bJKhX5hj6MjJhmQO9ApjDBRNpqr7 cZAQ== X-Gm-Message-State: AKGB3mJtmxz8G2YJfqE8pwuxdGPrllzMTNVcWQCjM3GYVatNC1p9hclt V9Dd2vIoMcOtqOKnEGWSylktfl4R X-Google-Smtp-Source: ACJfBot9BDQdW8Mlu2eMIoyozh9IVBrONy1nnkkm79Hlb9M2ZQd0Iiva04+Lcxna8uosWxhS7p8KzA== X-Received: by 10.107.189.6 with SMTP id n6mr6018061iof.127.1514587659250; Fri, 29 Dec 2017 14:47:39 -0800 (PST) Received: from mail-it0-f44.google.com (mail-it0-f44.google.com. [209.85.214.44]) by smtp.gmail.com with ESMTPSA id c23sm16762841iod.5.2017.12.29.14.47.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Dec 2017 14:47:38 -0800 (PST) Received: by mail-it0-f44.google.com with SMTP id f143so32895588itb.0; Fri, 29 Dec 2017 14:47:38 -0800 (PST) X-Received: by 10.36.0.209 with SMTP id 200mr47439116ita.55.1514587658741; Fri, 29 Dec 2017 14:47:38 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.15.193 with HTTP; Fri, 29 Dec 2017 14:47:38 -0800 (PST) In-Reply-To: References: <201712292208.vBTM8hpG048007@repo.freebsd.org> From: Conrad Meyer Date: Fri, 29 Dec 2017 14:47:38 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327362 - in head/usr.bin/find: . tests To: Oliver Pinter Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Dec 2017 22:47:46 -0000 On Fri, Dec 29, 2017 at 2:41 PM, Oliver Pinter wrote: > Why did you comment out these tests? I think unit tests are a good idea for this kind of change, which is why I wrote them. And I run them before commit. But I'm not interested in tilting at the test build infrastructure to actually enable them. Someone else can hook them up to the build if they want to. Conrad