From owner-svn-src-head@FreeBSD.ORG Mon Jun 2 20:51:51 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6FB8A271; Mon, 2 Jun 2014 20:51:51 +0000 (UTC) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 204B423EA; Mon, 2 Jun 2014 20:51:50 +0000 (UTC) Received: from [172.29.2.230] ([66.129.239.13]) (authenticated bits=0) by mail.xcllnt.net (8.14.9/8.14.9) with ESMTP id s52Kpk1B011069 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 2 Jun 2014 13:51:48 -0700 (PDT) (envelope-from marcel@xcllnt.net) Content-Type: multipart/signed; boundary="Apple-Mail=_5CF7BD56-2034-4A33-9483-AAF01FFEC99B"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net From: Marcel Moolenaar In-Reply-To: Date: Mon, 2 Jun 2014 13:51:40 -0700 Message-Id: References: <201406021754.s52Hsd1B039620@svn.freebsd.org> To: Juli Mallett X-Mailer: Apple Mail (2.1878.2) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 20:51:51 -0000 --Apple-Mail=_5CF7BD56-2034-4A33-9483-AAF01FFEC99B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Jun 2, 2014, at 12:54 PM, Juli Mallett wrote: > Log: > Introduce a procedural interface to the ifnet structure. *snip* > Could you say a little bit about why so few reviewers? Sorry, my bad. The change was proposed and discussed on arch@ with pointers to the diff. Previous incarnations have been sent to net@ as well. I should have mentioned something along those lines. > Also, why "if_t" rather than an opaque "struct ifnet" to minimize = churn, and also not conflict with other "if_t" types one might be using = in third-party kernel modules. This has been covered on arch@ as well. It's probably best if I refer you to the email thread on arch@ so as to not pull emails out of context: http://lists.freebsd.org/pipermail/freebsd-arch/2014-May/015379.html > It's a pretty general name, and that seems problematic. In general = am enthused about this happening, just minor implementation concerns. It's appreciated. --=20 Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_5CF7BD56-2034-4A33-9483-AAF01FFEC99B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlOM49wACgkQpgWlLWHuifbDrACggvPkO0bLhp+lwZn7b47Dusml YaoAoIiMz5ytsBqad08do0z88uWPcZ1S =W7x3 -----END PGP SIGNATURE----- --Apple-Mail=_5CF7BD56-2034-4A33-9483-AAF01FFEC99B--