From owner-svn-src-head@freebsd.org Fri Apr 15 13:26:46 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB9D8AECCAE for ; Fri, 15 Apr 2016 13:26:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ig0-x242.google.com (mail-ig0-x242.google.com [IPv6:2607:f8b0:4001:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 83E95136C for ; Fri, 15 Apr 2016 13:26:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ig0-x242.google.com with SMTP id g8so2967844igr.0 for ; Fri, 15 Apr 2016 06:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=8IILQKW63RU1ZsVNzL3G46WYbXrGOZViNk2pLUZc3kc=; b=kw8w2Y8raxmuZbtx3ULzjmE2TcOxzqRKxBtHCueT4NjceUI+b7k1tp96dyhEBvLWBy GrnZbWFXIuDHVfIQRqVYA6UPBP+/AUeQK5Sds8WLPVfw4zBzgNl/jg90Uk0aa9MjysGT O5t4y/dHPgQUuLgCVwZuHpx91S6dR6n8p2N3OU00gpS37kEYiUNYdzZFApTfIDOHmOPb 7tMfHQzpi09Mg0qFloLtszxYfHdMJT2pyLR2R00f8qk124sBYsgXpDb0VGJ3WZ1aUvHP 7hbEe+l6WGvtW4pGK9TPrWJkGUxi8dADZEMQCjcVl9GaiyU60uQXC7HhvL9hbwCksK/z quZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=8IILQKW63RU1ZsVNzL3G46WYbXrGOZViNk2pLUZc3kc=; b=NmQf9m2/S0zCQjk7gRVsBi7MOnc6ZVclg9dgZwHRoSPp2Hut91RkBzpBzP6YsmyykO ABO7MJM/jFVIMF8Xq5CC+PK4ZofT8H2jvDhrbDu95QvZeYBjkrbHvUrwOqx1olmyCeDK 0aIvV0V08FVKkD1XthIY9nqkAqgj1ws1zqbmm4UX/N+V0iJ8v4E+ttBUxoo65l2DdpgP ydL/k+EbhZcM3IecIAd17Lx8CUboqVnJT5CTElWE+qTqPJkxyFxkU2/GkL5F6EKBnqzV SaE/jliGvGaKaszHVMNJyx1SRDHMaG70vMRvikmhotiUhOtTE0Q/s638Q0/1FCP2DEOA erYw== X-Gm-Message-State: AOPr4FUxAD8cI9jEkmU8pqtY+7V0YE26YwIHP3GfgjVSLrdOiguHrb+wwFib3adx0Y5oniZHR6gGzTiBSNwSPQ== MIME-Version: 1.0 X-Received: by 10.50.110.99 with SMTP id hz3mr4788234igb.16.1460726805834; Fri, 15 Apr 2016 06:26:45 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.79.104.197 with HTTP; Fri, 15 Apr 2016 06:26:45 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201604150510.u3F5AWG7083767@repo.freebsd.org> Date: Fri, 15 Apr 2016 07:26:45 -0600 X-Google-Sender-Auth: 7sOErKRK51HFDVJP-ji35G0Qwow Message-ID: Subject: Re: svn commit: r298036 - head/sys/cam From: Warner Losh To: Howard Su Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 13:26:46 -0000 On Fri, Apr 15, 2016 at 12:05 AM, Howard Su wrote: > > On Fri, Apr 15, 2016 at 1:10 PM Warner Losh wrote: > >> Author: imp >> Date: Fri Apr 15 05:10:32 2016 >> New Revision: 298036 >> URL: https://svnweb.freebsd.org/changeset/base/298036 >> >> Log: >> Put function only used by CAM_NETFLIX_IOSCHED under that ifdef. >> >> I suggest to remove NETFLIX from the name. > It's the Netflix I/O scheduler as opposed to the default one. So the name is appropriate. It's better than CAM_WARNER_AWESOME_IOSCHED which is the only other choice possible... :) Warner > Modified: >> head/sys/cam/cam_iosched.c >> >> Modified: head/sys/cam/cam_iosched.c >> >> ============================================================================== >> --- head/sys/cam/cam_iosched.c Fri Apr 15 05:10:31 2016 (r298035) >> +++ head/sys/cam/cam_iosched.c Fri Apr 15 05:10:32 2016 (r298036) >> @@ -625,9 +625,11 @@ cam_iosched_cl_maybe_steer(struct contro >> /* Periph drivers set these flags to indicate >> work */ >> #define CAM_IOSCHED_FLAG_WORK_FLAGS ((0xffffu) << 16) >> >> +#ifdef CAM_NETFLIX_IOSCHED >> static void >> cam_iosched_io_metric_update(struct cam_iosched_softc *isc, >> sbintime_t sim_latency, int cmd, size_t size); >> +#endif >> >> static inline int >> cam_iosched_has_flagged_work(struct cam_iosched_softc *isc) >> @@ -1522,6 +1524,7 @@ cam_iosched_update(struct iop_stats *iop >> iop->sd = (int64_t)var < 0 ? 0 : isqrt64(var); >> } >> >> +#ifdef CAM_NETFLIX_IOSCHED >> static void >> cam_iosched_io_metric_update(struct cam_iosched_softc *isc, >> sbintime_t sim_latency, int cmd, size_t size) >> @@ -1541,6 +1544,7 @@ cam_iosched_io_metric_update(struct cam_ >> break; >> } >> } >> +#endif >> >> #ifdef DDB >> static int biolen(struct bio_queue_head *bq) >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >> >