From owner-svn-ports-head@freebsd.org  Thu Oct 19 18:00:57 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 763EDE42E63;
 Thu, 19 Oct 2017 18:00:57 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5777D754D2;
 Thu, 19 Oct 2017 18:00:57 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 9550E18D1E; Thu, 19 Oct 2017 18:00:56 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Steve Wills <swills@FreeBSD.org>
Cc: Shane <FreeBSD@ShaneWare.Biz>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r452419 - in head/graphics: . ptex ptex/files
References: <201710191310.v9JDAmdQ047764@repo.freebsd.org>
Date: Thu, 19 Oct 2017 20:00:51 +0200
In-Reply-To: <201710191310.v9JDAmdQ047764@repo.freebsd.org> (Steve Wills's
 message of "Thu, 19 Oct 2017 13:10:48 +0000 (UTC)")
Message-ID: <fuaf-c90s-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Oct 2017 18:00:57 -0000

Steve Wills <swills@FreeBSD.org> writes:

> +PORTNAME=	ptex
[...]
> +GH_PROJECT=	ptex

One of these is redundant.

> +PORTVERSION=	2.1.28
> +GH_TAGNAME=	v${PORTVERSION}

Use DISTVERSIONPREFIX.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex3

> +DOCS_BUILD_DEPENDS=	doxygen:devel/doxygen

Maybe rename to DOXYGEN, so users can disable it globally via OPTIONS_UNSET.
DOCS is enabled by default, so you may want to enable DOXYGEN as well.

https://lists.freebsd.org/pipermail/freebsd-ports/2015-March/098258.html
https://svnweb.freebsd.org/changeset/ports/428947
https://svnweb.freebsd.org/changeset/ports/429005
https://svnweb.freebsd.org/changeset/ports/429007
https://svnweb.freebsd.org/changeset/ports/429087
https://svnweb.freebsd.org/changeset/ports/429088
https://svnweb.freebsd.org/changeset/ports/429089
https://svnweb.freebsd.org/changeset/ports/429090
https://svnweb.freebsd.org/changeset/ports/429091
https://svnweb.freebsd.org/changeset/ports/429092
https://svnweb.freebsd.org/changeset/ports/429093
https://svnweb.freebsd.org/changeset/ports/429094
https://svnweb.freebsd.org/changeset/ports/429095
https://svnweb.freebsd.org/changeset/ports/429096
https://svnweb.freebsd.org/changeset/ports/429098
https://svnweb.freebsd.org/changeset/ports/429099
https://svnweb.freebsd.org/changeset/ports/429228 (reverts r429099)
https://svnweb.freebsd.org/changeset/ports/429229 (reverts r429097)

> +.include <bsd.port.options.mk>

Unused line. Nothing later uses .if/.for conditionals.

> ++#if !defined(__FreeBSD__)
> + #include <alloca.h>
> ++#endif

None of BSDs have <alloca.h>, including DragonFly which is a downstream
consumer of FreeBSD Ports.