From owner-cvs-all Mon Jan 14 2: 4: 2 2002 Delivered-To: cvs-all@freebsd.org Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id 54E2437B425 for ; Mon, 14 Jan 2002 02:03:46 -0800 (PST) Received: (qmail 18030 invoked from network); 14 Jan 2002 10:03:46 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 14 Jan 2002 10:03:46 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020113233830.E7984@elvis.mu.org> Date: Mon, 14 Jan 2002 02:03:06 -0800 (PST) From: John Baldwin To: Alfred Perlstein Subject: Re: cvs commit: src/sys/kern vfs_aio.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Alan Cox Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 14-Jan-02 Alfred Perlstein wrote: > * Alan Cox [020113 23:26] wrote: >> alc 2002/01/13 23:26:33 PST >> >> Modified files: >> sys/kern vfs_aio.c >> Log: >> o Correct the initialization of aiolio_zone: Each entry was 16 times >> larger >> than necessary. >> o Move a rarely-used goto label inside a critical section so that we >> don't >> perform an splnet() for which there is no corresponding splx(). >> o Remove unnecessary splnet()/splx() around accesses to >> kaioinfo::kaio_jobdone >> in aio_return(). >> o Use TAILQ_FOREACH for simple cases of iteration over >> kaioinfo::kaio_jobdone. > > I skipped over AIO for the fdlocking patches. Any chance you can > take a look at it? Erm, in the future can you please do this before committing? Or at least send out a HEADS UP saying that AIO is broken after your commit? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message