From owner-freebsd-audit  Sun Nov 19 12:34:17 2000
Delivered-To: freebsd-audit@freebsd.org
Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id A373437B479; Sun, 19 Nov 2000 12:34:07 -0800 (PST)
Received: from grondar.za (grapevine.grondar.za [196.7.18.17])
	by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id eAJKY4J16116;
	Sun, 19 Nov 2000 22:34:04 +0200 (SAST)
	(envelope-from mark@grondar.za)
Message-Id: <200011192034.eAJKY4J16116@gratis.grondar.za>
To: Kris Kennaway <kris@FreeBSD.ORG>
Cc: audit@FreeBSD.ORG
Subject: Re: bootpd patch 
References: <20001119032345.A91835@citusc17.usc.edu> 
In-Reply-To: <20001119032345.A91835@citusc17.usc.edu> ; from Kris Kennaway <kris@FreeBSD.ORG>  "Sun, 19 Nov 2000 03:23:45 PST."
Date: Sun, 19 Nov 2000 22:34:03 +0200
From: Mark Murray <mark@grondar.za>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> The following patches are taken from OpenBSD. Reviews, anyone?

Looks good, except the sizeof(...) have a degree of repetitiveness about
them (function/macro candidate), and the use of constants instead of
#defines in array sizes.

Apart from that, OK.

M
--
Mark Murray
Join the anti-SPAM movement: http://www.cauce.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message