Date: Thu, 14 Jul 2022 07:35:07 +0200 From: Matthias Fechner <mfechner@FreeBSD.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure Message-ID: <88109e04-ca58-2d47-b1ef-2b1e5d22a124@FreeBSD.org> In-Reply-To: <CAMHz58TnfW0H4X_iKseaa-y1M68q0Ea0XXNKUtngBS0fNvAiZw@mail.gmail.com> References: <202206301432.25UEWIi4077084@gitrepo.freebsd.org> <CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw@mail.gmail.com> <e3534f11-5199-d7a4-b651-02978dfb667c@FreeBSD.org> <CAMHz58TnfW0H4X_iKseaa-y1M68q0Ea0XXNKUtngBS0fNvAiZw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 12.07.2022 um 00:37 schrieb Po-Chuan Hsieh: > OK, the failure is about gitlab-ce but the commit message looks like > it causes the build failure of net/rubygem-omniauth-auth0. > > Anyway, you could try this patch [1]. Then we could drop > confusing net/rubygem-omniauth-oauth2-v1. > > [1] https://people.freebsd.org/~sunpoet/patch/gitlab-ce.txt I do not have the test setup here to test such a modification. For this you must setup authentication with auth0 and test that the login afterwards continue to work. But as the new versions will switch the master lib from version 1 to version 2, there is a risk it breaks the authentication. If you tested this and it does not break anything, you have my approval to commit it. Thanks. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88109e04-ca58-2d47-b1ef-2b1e5d22a124>