From owner-cvs-all Fri Apr 19 20:38:28 2002 Delivered-To: cvs-all@freebsd.org Received: from finntroll.newgold.net (Durham-ar1-4-64-252-019.dsl.genuity.net [4.64.252.19]) by hub.freebsd.org (Postfix) with SMTP id 4ED5337B41A for ; Fri, 19 Apr 2002 20:38:20 -0700 (PDT) Received: (qmail 17072 invoked by uid 1001); 20 Apr 2002 03:44:46 -0000 Date: Sat, 20 Apr 2002 03:44:46 +0000 From: "J. Mallett" To: "J. Mallett" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/uudecode uudecode.c Message-ID: <20020420034445.GH9585@FreeBSD.ORG> References: <200204200333.g3K3XeU36531@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200204200333.g3K3XeU36531@freefall.freebsd.org> User-Agent: Mutt/1.3.27i Organisation: FreeBSD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Apr 19, 2002 at 08:33:40PM -0700, J. Mallett wrote: > jmallett 2002/04/19 20:33:40 PDT > > Modified files: > usr.bin/uudecode uudecode.c > Log: > Use fwrite(3) to write out the decoded information, as the b64 decoding stuff > won't NUL terminate the string for us, and so we're liable to pick up trailing > garbage, possibly tons of it. Furthermore, a NUL could appear at any time in a binary file, and this is what was killing the decoding of David's shared libraries, I think, as they were being 1) corrupted due to trying to print as a C string without a terminator 2) truncated eary. Big conical hat to myself. -- jmallett@FreeBSD.org | C, MIPS, POSIX, UNIX, BSD, IRC Geek. http://www.FreeBSD.org | The Power to Serve "We all need mirrors to remind ourselves who we are -- I'm no different." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message