From owner-svn-src-all@freebsd.org Fri Jul 29 18:10:20 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03D5DBA7353 for ; Fri, 29 Jul 2016 18:10:20 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm16.bullet.mail.bf1.yahoo.com (nm16.bullet.mail.bf1.yahoo.com [98.139.212.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AEFBE1236 for ; Fri, 29 Jul 2016 18:10:19 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1469815818; bh=QVzCnp47ozMBuvYChquj8AUQlkv/5Fhrh4TJu4L2ZC0=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=gkjkTII44WvcpQS+55GA9NRvc1NUIjdOKsDeah5KEnoHhkFryJkc14E9dKaVCJWdVemsH2vNXuu2be4HqwJ2ZGeNVWhcIGPfHzuh+Ycsigg/sv0ZxT7j1XY3hyUSZ+tUlE7CRzIFS5TNvF4T7skBd/azJwFF27AcypyBydAwNvQyWbsQmjCcOgjfGvAWBVVxPwX7Rs57HbeeIGe4LUvjT6JUhy6Pyj0h3cfjWOmuWTdfkAWCvil9y1XENuqs/OiUgm2CRQbvJTFVi3/tgCfq8ZiXS0QRAqZzttmY2mD6aOJwkj/ps0dBJWGQfjMQ934p32bn4mF2sStqyRn5EbnXsQ== Received: from [66.196.81.171] by nm16.bullet.mail.bf1.yahoo.com with NNFMP; 29 Jul 2016 18:10:18 -0000 Received: from [68.142.230.77] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 29 Jul 2016 18:10:18 -0000 Received: from [127.0.0.1] by smtp234.mail.bf1.yahoo.com with NNFMP; 29 Jul 2016 18:10:18 -0000 X-Yahoo-Newman-Id: 98285.36077.bm@smtp234.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: zuMEhNUVM1nqekJ2hvojiTOWvdF7XVgCIRvomHfwp6kAF3t l3gp60G6qeWWIZUKgguFqahjMvfgxEmmy08B99FhJyD1YQ4BlFv0Hyg5QpWO tuGNW3GR2rWmP1MAm7rKVL_fBuIJOb6pJ7vWZC4XyTmceg..lNB71mKDET1i of1jDiuiC.LUsUKn4ycB2VHgrQxcxsA5DZnD1K.UxITFkzfX.XwMfCcovteG scvLx73ZZxywaYbZmgQXtHcMkF5iTBnjwyhgG9.0O.qznNC_MP7DYBYFgvKL HNPZrg.ODQ7i2WgGAJbKlPwRuR1pQBK3ZuXAxqpNbnfT5b2hnDfExekn6cZt Bo82_OduSNV4GCQ7Q9_pExQ8BgXXBGDp3TB4rTioAolDGqOxWwkZDqkpSZW1 W4wyEQHDoNZTJCJh2b8AmDXHiwHydQLT5XJ6j3OyGlu.csnvd8zTNzX3eI7. eZKICUULiiNmE5rFnnD_5SX8q6qluIFYutZIwxZrgVgqMDzVtNGqOZQOaf.v UFIOXFNrvLw.xv7qch0EvhQwrx1SOxJhtsO7nzT9.HiDJ4A-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r303484 - head/usr.bin/indent To: Benjamin Kaduk References: <201607291617.u6TGHsPE060673@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Message-ID: Date: Fri, 29 Jul 2016 13:10:26 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2016 18:10:20 -0000 On 07/29/16 11:24, Benjamin Kaduk wrote: > On Fri, Jul 29, 2016 at 11:20 AM, Benjamin Kaduk > wrote: > > On Fri, Jul 29, 2016 at 11:17 AM, Pedro F. Giffuni > wrote: > > Author: pfg > Date: Fri Jul 29 16:17:54 2016 > New Revision: 303484 > URL: https://svnweb.freebsd.org/changeset/base/303484 > > Log: > indent(1): Fix breakage caused by single comment following "else". > > indent(1) simply wasn't taught that "else" may be followed by > a comment > without any opening brace anywhere on the line, so it was very > confused > in such cases. > > > Wrong commit message? I see no 'else' in this change. > (I guess core's guidance is to revert and recommit with correct > message, these days.) > > > Nevermind, I think I see what's going on here, now. > No problem. It would be great to have more eyes helping review the changes here: https://github.com/pstef/freebsd_indent/commits/master I only got started with a first batch of them. Regards, Pedro.