From owner-svn-src-head@freebsd.org Sun Dec 20 04:34:36 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4958E4B79CB; Sun, 20 Dec 2020 04:34:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cz8rq6qt8z3t7V; Sun, 20 Dec 2020 04:34:35 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 0BK4YSxk076648 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 20 Dec 2020 06:34:31 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 0BK4YSxk076648 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 0BK4YSEj076647; Sun, 20 Dec 2020 06:34:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 20 Dec 2020 06:34:28 +0200 From: Konstantin Belousov To: Ryan Libby Cc: John Baldwin , src-committers , svn-src-all , svn-src-head , Alex Richardson Subject: Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc Message-ID: References: <202012190838.0BJ8cVJ3064816@repo.freebsd.org> <47e9db0f-14b4-0a0d-45c4-7e466e69711f@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4Cz8rq6qt8z3t7V X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 04:34:36 -0000 On Sat, Dec 19, 2020 at 08:27:31PM -0800, Ryan Libby wrote: > On a tangent, it might be neat to split out an rtld_bootstrap > (everything through init_rtld()) so that only the bootstrap code needs > to be compiled and linked with no-SSP. I looked at this some but I > figured there might not be appetite for a bunch of reorganization of > rtld just to enable SSP. Anyway the bootstrap code would still need > these particular libcompiler_rt functions to be no-SSP, as they get used > in the printf procedure, which I am guessing the bootstrap may need. Just my opinion. SSP is not too useful itself, and I believe it is useless in rtld, simply due to what rtld typically executes (matching static strings). Rototiling early rtld stages to get another bullet on the list of doubtful features should not be done.