From owner-svn-src-all@freebsd.org Fri Jun 12 17:59:08 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 434BA3411B9; Fri, 12 Jun 2020 17:59:08 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49k7lH46RCz3Zgv; Fri, 12 Jun 2020 17:59:07 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: by mail-oi1-x242.google.com with SMTP id a3so9486808oid.4; Fri, 12 Jun 2020 10:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=xuundVn0LmhVYos0FsiMGR3GpqyktcMGOoky1nC2sh0=; b=KU5gaZIrWG8/UFF62Du/H2Cn9h5Qo1fogGnCn/Z14q60wmKXPlTLcFMNjpnMJQ2Gq5 cWoWk6MB08pyCtsn++EyWvnqFUE4qj+o/A/MHk+8WIvV/Nqux9NENJz+a3/lb5uaGvhI AiOZPRZ12/CcIkKZcqcAqXaqPiVKvdzbfnQ/AyBRRsLlr8tIX9PZvvltWyEvEYrLys3e dtNoht+v9lE5SO4kulr0RtyGuChJxr7pyoNYID/b0djTwG0M4frbAkZ0ADggwRobloMh 5lHe04EgclAlzaBNXcuO6k1dUJHPEDwi9n6qiUs2TEpD1FOQR/rG+hm7P0LdI974URFU /vVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=xuundVn0LmhVYos0FsiMGR3GpqyktcMGOoky1nC2sh0=; b=eF7nSFX5bWcQAyggZK5EDiUWVpUWKKNrN926omG15LRUzOQGZGvTXJ0dG0llKT2vZf FtTK9YnQPl0i9dXSkrOqsrF3tLfIC6OBIkprrCOIgzOlb7hq5/R47X0OYnveAASaoa1P H/zISN7KGLPk5aDBdDnPymk8cwAJO1mt9ofHejV2dZIIk3/1/CLUr7L0qlkXsIDuVNPk tbCqNz8sg5y9l6cbN24Y86Qp/iomDi0g1I8nTuIk7R8ilaNBjkpCWVUyFh4g8uaif1yn I3sTZaI4MwMrFTWELcV8mgWHzQVzC+IVHh47S/lzlUfpmb5Z0L00T05AUuKs006Ls/Ip wy7g== X-Gm-Message-State: AOAM531MSea8Q0WwOAPHjji1zokT5yjx1ncXx0Q9cWErtv+/4/OxU43Z fkdSf9MIgBuzN8JasdhiLZsGPl9d2I6jMw== X-Google-Smtp-Source: ABdhPJxo5X8y8nuZfoJCrAhbuAJuZBcxAjC+Oga1I07q+bmhNJA5K+3vjsvrZ39czBTQn5/Uha+idw== X-Received: by 2002:aca:cc84:: with SMTP id c126mr103689oig.128.1591984745999; Fri, 12 Jun 2020 10:59:05 -0700 (PDT) Received: from 108-254-203-202.lightspeed.hstntx.sbcglobal.net (108-254-203-202.lightspeed.hstntx.sbcglobal.net. [108.254.203.202]) by smtp.gmail.com with ESMTPSA id p206sm1508402oib.16.2020.06.12.10.59.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2020 10:59:05 -0700 (PDT) From: Doug Moore X-Google-Original-From: Doug Moore Subject: Re: svn commit: r362110 - head/sys/compat/linuxkpi/common/include/linux To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202006121748.05CHmCAU037945@repo.freebsd.org> <204b885c-bf12-d140-987b-d1c684ec2049@selasky.org> <05f111e5-5702-9d2d-5f4c-2b00ade844a8@selasky.org> Message-ID: Date: Fri, 12 Jun 2020 12:59:02 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <05f111e5-5702-9d2d-5f4c-2b00ade844a8@selasky.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 49k7lH46RCz3Zgv X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=KU5gaZIr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of unkadoug@gmail.com designates 2607:f8b0:4864:20::242 as permitted sender) smtp.mailfrom=unkadoug@gmail.com X-Spamd-Result: default: False [-3.60 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.01)[-1.005]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.01)[-1.014]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::242:from]; NEURAL_HAM_SHORT(-0.58)[-0.585]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2020 17:59:08 -0000 As far as I know, by undoing the change that introduced the compilation error, I have fixed the compilation error.  If you mean to ask whether I intend to fix the underlying linuxkpi error, which motivated the earlier unfortunate change, then yes, I do.  I intend to make things better as soon as I can.  Thanks for your inquiry. Doug Moore On 2020-06-12 12:53, Hans Petter Selasky wrote: > On 2020-06-12 19:51, Hans Petter Selasky wrote: >> On 2020-06-12 19:48, Doug Moore wrote: >>> Author: dougm >>> Date: Fri Jun 12 17:48:12 2020 >>> New Revision: 362110 >>> URL: https://svnweb.freebsd.org/changeset/base/362110 >>> >>> Log: >>>    Revert r362108, as it breaks compilation. >>> >>> Modified: >>>    head/sys/compat/linuxkpi/common/include/linux/rbtree.h >>> >>> Modified: head/sys/compat/linuxkpi/common/include/linux/rbtree.h >>> ============================================================================== >>> >>> --- head/sys/compat/linuxkpi/common/include/linux/rbtree.h    Fri >>> Jun 12 17:31:38 2020    (r362109) >>> +++ head/sys/compat/linuxkpi/common/include/linux/rbtree.h    Fri >>> Jun 12 17:48:12 2020    (r362110) >>> @@ -37,8 +37,8 @@ >>>   struct rb_node { >>>       RB_ENTRY(rb_node)    __entry; >>>   }; >>> -#define    rb_left        RB_PTR(__entry.rbe_left) >>> -#define    rb_right    RB_PTR(__entry.rbe_right) >>> +#define    rb_left        __entry.rbe_left >>> +#define    rb_right    __entry.rbe_right >>>   /* >>>    * We provide a false structure that has the same bit pattern as >>> tree.h >>> >> >> Are you planning to fix those compilation errors? >> > > Or is the current code fine? > > --HPS >