Date: Fri, 12 Jun 2020 12:59:02 -0500 From: Doug Moore <unkadoug@gmail.com> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362110 - head/sys/compat/linuxkpi/common/include/linux Message-ID: <bf889e83-a1d3-ff44-7e70-31932ab26a7e@freebsd.org> In-Reply-To: <05f111e5-5702-9d2d-5f4c-2b00ade844a8@selasky.org> References: <202006121748.05CHmCAU037945@repo.freebsd.org> <204b885c-bf12-d140-987b-d1c684ec2049@selasky.org> <05f111e5-5702-9d2d-5f4c-2b00ade844a8@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
As far as I know, by undoing the change that introduced the compilation error, I have fixed the compilation error. If you mean to ask whether I intend to fix the underlying linuxkpi error, which motivated the earlier unfortunate change, then yes, I do. I intend to make things better as soon as I can. Thanks for your inquiry. Doug Moore On 2020-06-12 12:53, Hans Petter Selasky wrote: > On 2020-06-12 19:51, Hans Petter Selasky wrote: >> On 2020-06-12 19:48, Doug Moore wrote: >>> Author: dougm >>> Date: Fri Jun 12 17:48:12 2020 >>> New Revision: 362110 >>> URL: https://svnweb.freebsd.org/changeset/base/362110 >>> >>> Log: >>> Revert r362108, as it breaks compilation. >>> >>> Modified: >>> head/sys/compat/linuxkpi/common/include/linux/rbtree.h >>> >>> Modified: head/sys/compat/linuxkpi/common/include/linux/rbtree.h >>> ============================================================================== >>> >>> --- head/sys/compat/linuxkpi/common/include/linux/rbtree.h Fri >>> Jun 12 17:31:38 2020 (r362109) >>> +++ head/sys/compat/linuxkpi/common/include/linux/rbtree.h Fri >>> Jun 12 17:48:12 2020 (r362110) >>> @@ -37,8 +37,8 @@ >>> struct rb_node { >>> RB_ENTRY(rb_node) __entry; >>> }; >>> -#define rb_left RB_PTR(__entry.rbe_left) >>> -#define rb_right RB_PTR(__entry.rbe_right) >>> +#define rb_left __entry.rbe_left >>> +#define rb_right __entry.rbe_right >>> /* >>> * We provide a false structure that has the same bit pattern as >>> tree.h >>> >> >> Are you planning to fix those compilation errors? >> > > Or is the current code fine? > > --HPS >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bf889e83-a1d3-ff44-7e70-31932ab26a7e>