From owner-freebsd-ports@FreeBSD.ORG Sun Sep 28 08:37:11 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A10D916A4B3 for ; Sun, 28 Sep 2003 08:37:11 -0700 (PDT) Received: from web13407.mail.yahoo.com (web13407.mail.yahoo.com [216.136.175.65]) by mx1.FreeBSD.org (Postfix) with SMTP id BE2BD44017 for ; Sun, 28 Sep 2003 08:37:10 -0700 (PDT) (envelope-from giffunip@yahoo.com) Message-ID: <20030928153710.81198.qmail@web13407.mail.yahoo.com> Received: from [200.91.194.224] by web13407.mail.yahoo.com via HTTP; Sun, 28 Sep 2003 08:37:10 PDT Date: Sun, 28 Sep 2003 08:37:10 -0700 (PDT) From: "Pedro F. Giffuni" To: Erik Trulsson In-Reply-To: <20030928071402.GA72957@falcon.midgard.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii cc: freebsd-ports@FreeBSD.org Subject: Re: xview-clients port and the bento log X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2003 15:37:11 -0000 I see... (I did the last "cleaning" on that port years ago) Your patch is an option, another one is merging xview-clients into xview. I think the best would be to do something like ghostscript-x11 does, merge the xview-clients patches into the xview port and add the Clients target from the xview-clients port. Yeah, it's quite a job and it has to be done with some care. cheers, Pedro. --- Erik Trulsson wrote: ... > > The port itself is not quite broken (and the patch itself is fine), but > the port has a somewhat incestous relataionship with the xview port. > If you first do a 'make patch' in the xviw port, then 'make patch' in > the xview-clients port, then things will work fine. Otherwise they > won't. > This used to work automatically, but some time ago there were changes > made to the ports system as to exactly when build-time dependencies are > checked. It used to be prior to the extract target, but was moved to > just prior to the configure target. > Things ought to work fine, since xview-clients DEPENDS on xview, but > it doesn't work right for some reason. > > Anyway, the problem lies in how xview-clients depends on xview. > (And in the fact that both these ports seem quite dusty and in need of > a complete overhaul to have them updated to modern ports-practice, but > that seems like a lot of work.) > > The following patch to xview-clients seems to make the patches apply > cleanly, but I am not at all sure if this is the right way to solve the > problem: > > > Index: Makefile > =================================================================== > RCS file: /ncvs/ports/x11-toolkits/xview-clients/Makefile,v > retrieving revision 1.27 > diff -u -r1.27 Makefile > --- Makefile 20 Feb 2003 19:20:28 -0000 1.27 > +++ Makefile 28 Sep 2003 07:03:28 -0000 > @@ -18,6 +18,7 @@ > COMMENT= OpenLook applications and man pages > > DEPENDS= ${PORTSDIR}/x11-toolkits/xview:install > +PATCH_DEPENDS= /nonexistent:${PORTSDIR}/x11-toolkits/xview:patch > > USE_X_PREFIX= yes > EXTRACT_ONLY= # empty > > > > > > > -- > > Erik Trulsson > ertr1013@student.uu.se __________________________________ Do you Yahoo!? The New Yahoo! Shopping - with improved product search http://shopping.yahoo.com