From owner-svn-src-all@freebsd.org Fri Sep 30 14:13:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 337F4C02F86; Fri, 30 Sep 2016 14:13:58 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A515D131; Fri, 30 Sep 2016 14:13:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u8UEDqOW019614 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 30 Sep 2016 17:13:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u8UEDqOW019614 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u8UEDqpm019613; Fri, 30 Sep 2016 17:13:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 30 Sep 2016 17:13:52 +0300 From: Konstantin Belousov To: Baptiste Daroussin Cc: David C Somayajulu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306284 - head/sys/dev/bxe Message-ID: <20160930141352.GR38409@kib.kiev.ua> References: <201609232318.u8NNIsxj072044@repo.freebsd.org> <20160930140127.ou5a6pjzrfc2ovew@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160930140127.ou5a6pjzrfc2ovew@ivaldir.etoilebsd.net> User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 14:13:58 -0000 On Fri, Sep 30, 2016 at 04:01:27PM +0200, Baptiste Daroussin wrote: > On Fri, Sep 23, 2016 at 11:18:54PM +0000, David C Somayajulu wrote: > > Author: davidcs > > Date: Fri Sep 23 23:18:54 2016 > > New Revision: 306284 > > URL: https://svnweb.freebsd.org/changeset/base/306284 > > > > Log: > > Fixes for issues under high workloads > > > > MFC after:5 days > > Please do not MFC as this change makes the kernel panic as soon as one setup the > network: > > I had to revert the patch to get my machine running again > > bxe0@pci0:1:0:0: class=0x020000 card=0x06361028 chip=0x168e14e4 rev=0x10 hdr=0x00 > vendor = 'Broadcom Corporation' > device = 'NetXtreme II BCM57810 10 Gigabit Ethernet' > class = network > subclass = ethernet > bxe1@pci0:1:0:1: class=0x020000 card=0x06361028 chip=0x168e14e4 rev=0x10 hdr=0x00 > vendor = 'Broadcom Corporation' > device = 'NetXtreme II BCM57810 10 Gigabit Ethernet' > class = network > subclass = ethernet > > With the following trace: > _callout_init_lock() at _callout_init_lock+0xa8/frame 0xfffffe201bde8370 > _timeout_task_init() at _timeout_task_init+0x31/frame 0xfffffe201bde8390 > bxe_nic_load() at bxe_nic_load+0x128a/frame 0xfffffe201bde8610 > bxe_init_locked() at bxe_init_locked+0xd16/frame 0xfffffe201bde8690 > bxe_init() at bxe_init+0x2f/frame 0xfffffe201bde86b0 > ether_ioctl() at ether_ioctl+0x4c/frame 0xfffffe201bde86e0 > in_control() at in_control+0x882/frame 0xfffffe201bde8760 > ifioctl() at ifioctl+0xdc1/frame 0xfffffe201bde87f0 > kern_ioctl() at kern_ioctl+0x246/frame 0xfffffe201bde8850 > The issue seems to be that the bxe_interrupt_attach() creates fast taskqueue, i.e. the taskqueue lock is spinlock. Then the queue is passed to TIMEOUT_TASK_INIT(), which can only operate with the sleepable mutex locks.