Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Mar 2013 02:54:26 GMT
From:      Pedro Giffuni <giffunip@tutopia.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/176935: Update emulators/x48
Message-ID:  <201303140254.r2E2sQxE054463@red.freebsd.org>
Resent-Message-ID: <201303140300.r2E300rA028219@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         176935
>Category:       ports
>Synopsis:       Update emulators/x48
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 14 03:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Pedro Giffuni
>Release:        9.1-STABLE
>Organization:
>Environment:
FreeBSD pcbsd-3938 9.1-STABLE FreeBSD 9.1-STABLE #0 r248173: Mon Mar 11 15:53:49 COT 2013     pfg@pcbsd-3938:/usr/src/sys/amd64/compile/DELL  amd64

>Description:
Include a couple of fixes from upstream:

- Fix timer bug causing bogus idle poweroffs while typing
  or immediately after turning on.
- Call to strcpy causes buffer overflow.
>How-To-Repeat:
While here, note that berlios seems to be now part of sourceforge
but port.sites.mk doesn't know about it.
>Fix:


Patch attached with submission follows:

Index: x48/files/patch-src+debugger.c
===================================================================
--- x48/files/patch-src+debugger.c	(revision 0)
+++ x48/files/patch-src+debugger.c	(working copy)
@@ -0,0 +1,13 @@
+--- src/debugger.c	2011/08/10 05:36:10	57
++++ src/debugger.c	2011/08/10 05:38:58	58
+@@ -1933,8 +1933,8 @@
+ 	      free (old_line);
+               old_line = (char *) 0;
+ 	    }
+-	  cl = strcpy ((char *) malloc (strlen (rl)), rl);
+-	  old_line = strcpy ((char *) malloc (strlen (rl)), rl);
++	  cl = strdup (rl);
++	  old_line = strdup (rl); 
+ #ifdef HAVE_READLINE
+ 	  add_history (rl);
+ #endif
Index: x48/files/patch-src+timer.c
===================================================================
--- x48/files/patch-src+timer.c	(revision 0)
+++ x48/files/patch-src+timer.c	(working copy)
@@ -0,0 +1,11 @@
+--- src/timer.c	2011/08/10 02:29:47	51
++++ src/timer.c	2011/08/10 02:32:11	52
+@@ -509,7 +509,7 @@
+     {
+       set_0_time += adj_time;
+       time_offset += adj_time;
+-      access_time - adj_time;
++      access_time -= adj_time;
+   
+ #ifdef DEBUG_TIMER_ADJUST
+       fprintf(stderr, "Time adjusted by ");


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303140254.r2E2sQxE054463>