From owner-svn-src-head@freebsd.org  Fri Jan 22 06:25:18 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0C8AA8CF67;
 Fri, 22 Jan 2016 06:25:18 +0000 (UTC)
 (envelope-from lstewart@freebsd.org)
Received: from lauren.room52.net (lauren.room52.net [210.50.193.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 8A7781AE2;
 Fri, 22 Jan 2016 06:25:18 +0000 (UTC)
 (envelope-from lstewart@freebsd.org)
Received: from lgwl-lstewart2.corp.netflix.com
 (c110-22-60-167.eburwd6.vic.optusnet.com.au [110.22.60.167])
 by lauren.room52.net (Postfix) with ESMTPSA id 776067E81E;
 Fri, 22 Jan 2016 17:19:51 +1100 (EST)
Subject: Re: svn commit: r294536 - head/sys/netinet
To: Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201601212253.u0LMrC7B016136@repo.freebsd.org>
From: Lawrence Stewart <lstewart@freebsd.org>
X-Enigmail-Draft-Status: N1110
Message-ID: <56A1C9F6.2010708@freebsd.org>
Date: Fri, 22 Jan 2016 17:19:34 +1100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <201601212253.u0LMrC7B016136@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=2.4 required=5.0 tests=DNS_FROM_AHBL_RHSBL,
 T_FRT_STOCK2,UNPARSEABLE_RELAY autolearn=no version=3.3.2
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 06:25:18 -0000

Hi Gleb,

On 01/22/16 09:53, Gleb Smirnoff wrote:
> Author: glebius
> Date: Thu Jan 21 22:53:12 2016
> New Revision: 294536
> URL: https://svnweb.freebsd.org/changeset/base/294536
> 
> Log:
>   Refactor TCP_CONGESTION setsockopt handling:
>   - Use M_TEMP instead of stack variable.
>   - Unroll error handling, removing several levels of indentation.

As noted privately elsewhere, this change introduces races with respect
to CC algorithm module unloading which will need to be fixed. Just
mentioning it again publicly so others are aware of it.

Cheers,
Lawrence