Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Jan 2016 17:19:34 +1100
From:      Lawrence Stewart <lstewart@freebsd.org>
To:        Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r294536 - head/sys/netinet
Message-ID:  <56A1C9F6.2010708@freebsd.org>
In-Reply-To: <201601212253.u0LMrC7B016136@repo.freebsd.org>
References:  <201601212253.u0LMrC7B016136@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Gleb,

On 01/22/16 09:53, Gleb Smirnoff wrote:
> Author: glebius
> Date: Thu Jan 21 22:53:12 2016
> New Revision: 294536
> URL: https://svnweb.freebsd.org/changeset/base/294536
> 
> Log:
>   Refactor TCP_CONGESTION setsockopt handling:
>   - Use M_TEMP instead of stack variable.
>   - Unroll error handling, removing several levels of indentation.

As noted privately elsewhere, this change introduces races with respect
to CC algorithm module unloading which will need to be fixed. Just
mentioning it again publicly so others are aware of it.

Cheers,
Lawrence



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56A1C9F6.2010708>