From owner-cvs-src  Sun Mar 16  3:23:15 2003
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 47A9737B405; Sun, 16 Mar 2003 03:23:07 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 048F543F3F; Sun, 16 Mar 2003 03:23:06 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA01341;
	Sun, 16 Mar 2003 22:22:43 +1100
Date: Sun, 16 Mar 2003 22:22:42 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "M. Warner Losh" <imp@bsdimp.com>
Cc: des@ofug.org, "" <mdodd@FreeBSD.org>,
	"" <src-committers@FreeBSD.org>, "" <cvs-src@FreeBSD.org>,
	"" <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/net if_iso88025subr.c
In-Reply-To: <20030315.173849.103229416.imp@bsdimp.com>
Message-ID: <20030316222107.W13549@gamplex.bde.org>
References: <200303152237.h2FMbCCZ012310@repoman.freebsd.org>
 <xzpwuj0citu.fsf@flood.ping.uio.no> <20030315.173849.103229416.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Sender: owner-cvs-src@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-src.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-src>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-src>
X-Loop: FreeBSD.ORG

On Sat, 15 Mar 2003, M. Warner Losh wrote:

> In message: <xzpwuj0citu.fsf@flood.ping.uio.no>
>             des@ofug.org (Dag-Erling Sm=F8rgrav) writes:
> : "Matthew N. Dodd" <mdodd@FreeBSD.org> writes:
> : >   Log:
> : >   - Style(9) changes.
> : >   - Remove unneeded assignment.
> : >   - Increment if_oerrors as per if_fddisubr.c.
> : >   - Wrap ISO code with conditional.
> :
> : This was the 14th consecutive commit to the same file in under 6
> : hours.  I think that's some kind of record...  Next time, please test
> : before committing.
>
> I don't see Matt's changes as a lack of testing.  he's doing what
> people have always done.  I did it many times in the oldcard code when
> I wanted to make each change separately on purpose.

Yes, please keep separate changes separate, even if it takes longer to
test each step.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message