From owner-p4-projects@FreeBSD.ORG  Tue Nov  2 21:11:20 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4953116A4EB; Tue,  2 Nov 2004 21:11:20 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DDFD116A505
	for <perforce@FreeBSD.org>; Tue,  2 Nov 2004 21:11:19 +0000 (GMT)
Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AC4E943D1D
	for <perforce@FreeBSD.org>; Tue,  2 Nov 2004 21:11:19 +0000 (GMT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 20851 invoked from network); 2 Nov 2004 21:11:19 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <perforce@FreeBSD.org>; 2 Nov 2004 21:11:19 -0000
Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA2LAuYS070948;
	Tue, 2 Nov 2004 16:11:15 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@FreeBSD.org>
Date: Tue, 2 Nov 2004 16:21:05 -0500
User-Agent: KMail/1.6.2
References: <200411012326.iA1NQP1j067198@repoman.freebsd.org>
In-Reply-To: <200411012326.iA1NQP1j067198@repoman.freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200411021621.05815.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 64073 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Nov 2004 21:11:21 -0000

On Monday 01 November 2004 06:26 pm, Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=64073
>
> Change 64073 by peter@peter_daintree on 2004/11/01 23:26:03
>
> 	whoops. need sched_lock around this.

You can probably #ifdef SMP this, btw.  Also, don't commit this until I get my 
Alpha SMP patch submitted, because on Alpha the BSP isn't always CPU 0 (yet).

> Affected files ...
>
> .. //depot/projects/hammer/sys/kern/kern_shutdown.c#29 edit
>
> Differences ...
>
> ==== //depot/projects/hammer/sys/kern/kern_shutdown.c#29 (text+ko) ====
>
> @@ -248,7 +248,9 @@
>  	static int first_buf_printf = 1;
>
>  	/* Do all shutdown processing on cpu0 */
> +	mtx_lock_spin(&sched_lock);
>  	sched_bind(curthread, 0);
> +	mtx_unlock_spin(&sched_lock);
>
>  	/* collect extra flags that shutdown_nice might have set */
>  	howto |= shutdown_howto;

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org