Date: Tue, 2 Nov 2004 16:21:05 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Peter Wemm <peter@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 64073 for review Message-ID: <200411021621.05815.jhb@FreeBSD.org> In-Reply-To: <200411012326.iA1NQP1j067198@repoman.freebsd.org> References: <200411012326.iA1NQP1j067198@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 01 November 2004 06:26 pm, Peter Wemm wrote: > http://perforce.freebsd.org/chv.cgi?CH=64073 > > Change 64073 by peter@peter_daintree on 2004/11/01 23:26:03 > > whoops. need sched_lock around this. You can probably #ifdef SMP this, btw. Also, don't commit this until I get my Alpha SMP patch submitted, because on Alpha the BSP isn't always CPU 0 (yet). > Affected files ... > > .. //depot/projects/hammer/sys/kern/kern_shutdown.c#29 edit > > Differences ... > > ==== //depot/projects/hammer/sys/kern/kern_shutdown.c#29 (text+ko) ==== > > @@ -248,7 +248,9 @@ > static int first_buf_printf = 1; > > /* Do all shutdown processing on cpu0 */ > + mtx_lock_spin(&sched_lock); > sched_bind(curthread, 0); > + mtx_unlock_spin(&sched_lock); > > /* collect extra flags that shutdown_nice might have set */ > howto |= shutdown_howto; -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411021621.05815.jhb>