Date: Fri, 24 Feb 2023 23:39:06 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269754] multimedia/jellyfin: Add port with jellyfish combined version 10.8.9 Message-ID: <bug-269754-7788-odMXwp65c7@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-269754-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-269754-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269754 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |fuz@FreeBSD.org Assignee|ports-bugs@FreeBSD.org |fuz@FreeBSD.org --- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> --- Review: - I see that you bundle libSkiaSharp.so as a binary file (o.O) Could you check if this file can be unbundled or built from source? - LICENSE_COMB=3Ddual means that either of the licenses can be used. Is t= his=20 correct? If multiple licenses apply at the same time, please use LICENSE_COMB=3Dmulti - consider replacing amd64 with ${ARCH} in distfiles to ensure that the po= rt break in an obvious place when compilation on another architecture is tr= ied - you seem to replace jellyfin with ${PORTNAME} in lots of places. I recommend only using ${PORTNAME} in places where changing the PORTNAME would not b= reak the build. Just because it's the string jellyfin doesn't mean that it is ${PORTNAME}. - why is the one file in PLIST_FILES instead of in pkg-plist? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-269754-7788-odMXwp65c7>