From owner-p4-projects@FreeBSD.ORG Mon Jul 7 15:58:51 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0B1091065670; Mon, 7 Jul 2008 15:58:51 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C31BA1065680; Mon, 7 Jul 2008 15:58:50 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.74]) by mx1.freebsd.org (Postfix) with ESMTP id 8D40E8FC1A; Mon, 7 Jul 2008 15:58:50 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtp017-bge351000.mac.com (asmtp017-bge351000 [10.150.69.80]) by smtpoutm.mac.com (Xserve/smtpout011/MantshX 4.0) with ESMTP id m67Fwonx026618; Mon, 7 Jul 2008 08:58:50 -0700 (PDT) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp017.mac.com (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) with ESMTPSA id <0K3N00H288E1EDA0@asmtp017.mac.com>; Mon, 07 Jul 2008 08:58:50 -0700 (PDT) Sender: xcllnt@mac.com Message-id: <42CDD177-3EA8-4C87-9A70-1A2F4F1EB42D@mac.com> From: Marcel Moolenaar To: Takahashi Yoshihiro In-reply-to: <20080707.174208.94913728.nyan@jp.FreeBSD.org> Date: Mon, 07 Jul 2008 08:58:48 -0700 References: <200807051943.m65JhHZ6066371@repoman.freebsd.org> <20080706.110943.226722229.nyan@jp.FreeBSD.org> <20080707.174208.94913728.nyan@jp.FreeBSD.org> X-Mailer: Apple Mail (2.926) Cc: marcel@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 144741 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2008 15:58:51 -0000 On Jul 7, 2008, at 1:42 AM, Takahashi Yoshihiro wrote: > In article > Marcel Moolenaar writes: > >>> These are wrong. RSA98-III is based on ns8250 and has extended FIFO >>> buffer. So I think that the uart_rsa_class should be added. >> >> Oh. In your patch you define it as i8251. I only refactored >> the code. Also, the ns8250 class already supports extended >> FIFOs, so we don't need a separate class for that. I'll >> change it... > > No. My code set sc_class to uart_rsa_class. It's your mistake. Ah yes, you're right. > And then I found another problem in uart_bus_isa.c. In your code > non-PnP devices for pc98 cannot probe. My original code was no > problem... Could you be a bit more specific? -- Marcel Moolenaar xcllnt@mac.com