From owner-freebsd-java@FreeBSD.ORG  Wed Sep 17 18:14:31 2014
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EE1DD521;
 Wed, 17 Sep 2014 18:14:30 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C2F19286;
 Wed, 17 Sep 2014 18:14:30 +0000 (UTC)
Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net
 [173.70.85.31])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id C40E0B979;
 Wed, 17 Sep 2014 14:14:29 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Andriy Gapon <avg@freebsd.org>
Subject: Re: svn commit: r271635 - in head: lib/libc/sys sys/vm
Date: Wed, 17 Sep 2014 11:03:29 -0400
Message-ID: <45601526.3eIXIxKgkH@ralph.baldwin.cx>
User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; )
In-Reply-To: <54183D4D.3050907@FreeBSD.org>
References: <201409151720.s8FHKDFs099885@svn.freebsd.org>
 <54183D4D.3050907@FreeBSD.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Wed, 17 Sep 2014 14:14:29 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, freebsd-java@freebsd.org
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java/>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Sep 2014 18:14:31 -0000

On Tuesday, September 16, 2014 04:38:21 PM Andriy Gapon wrote:
> On 15/09/2014 20:20, John Baldwin wrote:
> > Author: jhb
> > Date: Mon Sep 15 17:20:13 2014
> > New Revision: 271635
> > URL: http://svnweb.freebsd.org/changeset/base/271635
> > 
> > Log:
> >   Add stricter checking of some mmap() arguments:
> >   - Fail with EINVAL if an invalid protection mask is passed to mmap().
> >   - Fail with EINVAL if an unknown flag is passed to mmap().
> >   - Fail with EINVAL if both MAP_PRIVATE and MAP_SHARED are passed to
> >   mmap().
> >   - Require one of either MAP_PRIVATE or MAP_SHARED for non-anonymous
> >   
> >     mappings.
> 
> This broke Java, at least java/openjdk7, for me:
> 
>  25323 java     CALL
> mmap(0,0x3000000,0x3<PROT_READ|PROT_WRITE>,0x1042<MAP_PRIVATE|MAP_NORESERVE|
> MAP_ANON>,0xffffffff,0) 25323 java     RET   mmap -1 errno 22 Invalid
> argument
>  25323 java     CALL  write(0x1,0x7fffffbfd450,0x2b)
>  25323 java     GIO   fd 1 wrote 43 bytes
>        "Error occurred during initialization of VM
>        "
>  25323 java     RET   write 43/0x2b
>  25323 java     CALL  write(0x1,0x80209a1e2,0x2d)
>  25323 java     GIO   fd 1 wrote 45 bytes
>        "Could not reserve enough space for code cache"
> 
> It seems that MAP_NORESERVE presence could be detected in sys/mman.h and
> then it is used for some reason.
> I guess that the port can be easily fixed, but this commit breaks
> compatibility with older binaries.  Perhaps MAP_NORESERVE should be removed
> as well given that we do not actually implement it.

I've allowed it for now, but I do intend on removing it in 11.

-- 
John Baldwin