From owner-freebsd-tinderbox@FreeBSD.ORG  Thu Mar 18 10:00:41 2004
Return-Path: <owner-freebsd-tinderbox@FreeBSD.ORG>
Delivered-To: freebsd-tinderbox@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E54B616A4D3; Thu, 18 Mar 2004 10:00:40 -0800 (PST)
Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 92FDC43D5A; Thu, 18 Mar 2004 10:00:34 -0800 (PST)
	(envelope-from marcel@xcllnt.net)
Received: from ns1.xcllnt.net (localhost [127.0.0.1])
	by ns1.xcllnt.net (8.12.11/8.12.11) with ESMTP id i2II0SGS060886;
	Thu, 18 Mar 2004 10:00:28 -0800 (PST)
	(envelope-from marcel@ns1.xcllnt.net)
Received: (from marcel@localhost)
	by ns1.xcllnt.net (8.12.11/8.12.11/Submit) id i2II0S6X060885;
	Thu, 18 Mar 2004 10:00:28 -0800 (PST)
	(envelope-from marcel)
Date: Thu, 18 Mar 2004 10:00:28 -0800
From: Marcel Moolenaar <marcel@xcllnt.net>
To: Dag-Erling Sm?rgrav <des@des.no>
Message-ID: <20040318180028.GA60788@ns1.xcllnt.net>
References: <20040317040254.386947303A@freebsd-current.sentex.ca>
	<xzpad2fhixn.fsf@dwp.des.no> <20040317113931.GF49920@ip.net.ua>
	<20040317200307.GA46126@ip.net.ua>
	<20040317205104.GA29066@dhcp01.pn.xcllnt.net>
	<20040317213014.GB46747@ip.net.ua>
	<20040318084128.GA59199@dhcp01.pn.xcllnt.net> <xzpu10m5q73.fsf@dwp.des.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xzpu10m5q73.fsf@dwp.des.no>
User-Agent: Mutt/1.5.5.1i
cc: current@freebsd.org
cc: Ruslan Ermilov <ru@freebsd.org>
cc: ia64@freebsd.org
cc: FreeBSD Tinderbox <tinderbox@freebsd.org>
Subject: sys/dev/sound/pci/vibes.c bug? [was: Re: [current tinderbox]
	failure on ia64/ia64]
X-BeenThere: freebsd-tinderbox@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Tinderbox reports, responses, and meta-comments
	<freebsd-tinderbox.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-tinderbox>,
	<mailto:freebsd-tinderbox-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-tinderbox>
List-Post: <mailto:freebsd-tinderbox@freebsd.org>
List-Help: <mailto:freebsd-tinderbox-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-tinderbox>,
	<mailto:freebsd-tinderbox-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Mar 2004 18:00:41 -0000

On Thu, Mar 18, 2004 at 12:50:56PM +0100, Dag-Erling Sm?rgrav wrote:
> Marcel Moolenaar <marcel@xcllnt.net> writes:
> > The source code appears to be fishy. The variable v is never used.
> > It's only defined. If you change the "return mask" to a "return v",
> > the warning goes away.
> 
> I suspect that there's a line missing:
> 
> @@ -548,4 +548,5 @@
>         }
>         DEB(printf("sv_mix_setrecsrc: mask 0x%08x adc_input 0x%02x\n", mask, v));
> +       sv_indirect_set(sc, SV_REG_ADC_INPUT, v);
>         return mask;
>  }
> 
> although I have no way of testing this.

Me neither. If this is likely to be missing and we don't have a
maintainer for the code, I suggest we just commit it. The function
cannot be more wrong than it is without the change...

[Subject line changed to attract PCM maintainer(s)]

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel@xcllnt.net