From nobody Wed Jul 29 17:49:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h9KZn1Tg2z6mZnW for ; Wed, 29 Jul 2026 17:49:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h9KZm5K7fz3jXx for ; Wed, 29 Jul 2026 17:49:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785347344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lgCxxqKwEG2d9RGE044Q/zND7BbDc3EgHRM2GivT4So=; b=By0NWk29TSMvJIjquYPgRgBwXsrdkprB9wjWBZnLLTG+7s47odnLhH3GPUPNCLSMB1D2MJ oLPOv4/Q3sRX1AoWUwS0BK2Xf90w/SNdMp1rgZZso30v34XYOHhOkguItMlqSi/m1Bv9iB 9ZnFxwdzxJZJZ6Ou4ux7gl/I+dZXG6ziP/3jwLydV4a1KERPO+PoFaBnA1roNTIjU2l1mO Nd1Km5rnrZbROE0u1i8jowEOJnwSqSmCRnyByTo8cc4PjMyJzoqPYTmMic8katKWaxC9FF VzFx4eY0exNmWu7beX/pCo5qv53BWIyrPVxxoI09Vd76oFI/nL+9+Ks7DbEGeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785347344; a=rsa-sha256; cv=none; b=q4H7u65kHOafSIF9PvAFf6WOyUs2C0Disagw2d/kz96+RLouVY2JU3+0HjQiV7mRO63gL4 J8S2bA/5o7nR+YwEbi17UL3ZUAfePv4ONMO6OarcIiWJcL970d9z2GKZazrzmmrl6OWkno Y7wMwSoMufbHjA9Aj8vqWDgRIsqPTtMpr6zVxk4oGYa6IwdpxJ0SSb2YzXM0JBaJJgRrZy 6/yib2na+QT0cb0wo4ZYPXtbSAOmxv+kLVScJAZ/1ieQX93uY6/h2qAImyvmza1FZg+FHm 7Ht55UQBh9N0nHIsNS18U88aelGPINWNpvhWlCWWbnIrMRamnconzOQsYATBxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785347344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lgCxxqKwEG2d9RGE044Q/zND7BbDc3EgHRM2GivT4So=; b=lnyc7U7SJdVNfokRIAUNwbyrEAv0JAAQM1vGj0CQVXdEwEJyEs72nsrW14ApLbKy65ubFB 0EKzOeTWayLfG/kR5/0iRTVCHkU8S4+QvXu1dhSUuSXNvmbUA2o1pjUhYcfK3li1IyrrvE A7NCd0fJtNK4l2Etg9glEBP+tyB+n3nAMfJHpx4mg/6ijt2s3vgWVU2mk+WRsbGPqOOq1A 7OV5NVrGaqRywYUaq8z7mOKtyGag99M2+M4/Zz8NI7BaBpBRrc7C4LJQaPiH4HGDSMZIJR UE+YQYwSXt2XNx6NcRyBEmiezMgc09MastN1Ul3Mhyn8U/MyeGy/B2egcV89Qw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h9KZm31tgzcsk for ; Wed, 29 Jul 2026 17:49:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bb00 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Jul 2026 17:49:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 89a88e4f2ddc - stable/14 - coredump: Don't assume that the number of ELF segments is consistent List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 89a88e4f2ddc34221105a2d82407ce4337322808 Auto-Submitted: auto-generated Date: Wed, 29 Jul 2026 17:49:04 +0000 Message-Id: <6a6a3d10.3bb00.393eb33d@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=89a88e4f2ddc34221105a2d82407ce4337322808 commit 89a88e4f2ddc34221105a2d82407ce4337322808 Author: Mark Johnston AuthorDate: 2026-07-27 15:42:49 +0000 Commit: Mark Johnston CommitDate: 2026-07-29 17:48:54 +0000 coredump: Don't assume that the number of ELF segments is consistent In an ELF coredump, each dumped vm_map_entry is represented by a segment. __elfN(coredump) first computes the number of segments by looping over the vm_map entries (in each_dumpable_segment()), then allocates a buffer to hold the ELF header and program headers, then loops over the entries again to populate the program headers. each_dumpable_segment() holds the vm_map read lock, but that lock is dropped between the two calls. If the map is shared with another process, via rfork(), then the map can change. cb_put_phdr() did not account for this, and so could write out of bounds. Add a check to prevent this; simply do not write out excess segments. Approved by: so Security: FreeBSD-SA-26:55.elf Security: CVE-2026-58088 Reported by: Maik Muench of Secfault Security Reviewed by: kib, emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58416 --- sys/kern/imgact_elf.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/sys/kern/imgact_elf.c b/sys/kern/imgact_elf.c index ff482ca5d658..4dd700b23325 100644 --- a/sys/kern/imgact_elf.c +++ b/sys/kern/imgact_elf.c @@ -1533,6 +1533,8 @@ typedef void (*segment_callback)(vm_map_entry_t, void *); struct phdr_closure { Elf_Phdr *phdr; /* Program header to fill in */ Elf_Off offset; /* Offset of segment in core file */ + int numsegs; /* Maximum number of segments */ + int nextseg; /* Next segment to fill in */ }; struct note_info { @@ -1647,10 +1649,15 @@ __elfN(coredump)(struct thread *td, struct vnode *vp, off_t limit, int flags) } /* - * Allocate memory for building the header, fill it up, - * and write it out following the notes. + * Allocate memory for building the header, fill it up, and write it out + * following the notes. + * + * Note that a process sharing our vmspace might be concurrently + * mutating the map, in which case we could populate fewer than + * seginfo.count headers. Zero the buffer to ensure that unpopulated + * headers are still initialized. */ - hdr = malloc(hdrsize, M_TEMP, M_WAITOK); + hdr = malloc(hdrsize, M_TEMP, M_WAITOK | M_ZERO); error = __elfN(corehdr)(¶ms, seginfo.count, hdr, hdrsize, ¬elst, notesz, flags); @@ -1703,6 +1710,11 @@ cb_put_phdr(vm_map_entry_t entry, void *closure) struct phdr_closure *phc = (struct phdr_closure *)closure; Elf_Phdr *phdr = phc->phdr; + if (phc->nextseg >= phc->numsegs) { + /* Only write as many headers as we have space for. */ + return; + } + phc->offset = round_page(phc->offset); phdr->p_type = PT_LOAD; @@ -1715,6 +1727,8 @@ cb_put_phdr(vm_map_entry_t entry, void *closure) phc->offset += phdr->p_filesz; phc->phdr++; + + phc->nextseg++; } /* @@ -1977,6 +1991,8 @@ __elfN(puthdr)(struct thread *td, void *hdr, size_t hdrsize, int numsegs, /* All the writable segments from the program. */ phc.phdr = phdr; phc.offset = round_page(hdrsize + notesz); + phc.numsegs = numsegs; + phc.nextseg = 0; each_dumpable_segment(td, cb_put_phdr, &phc, flags); }