Date: Sat, 21 Nov 2015 22:25:18 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 204725] |make makepatch| inserts context junk after r401709 Message-ID: <bug-204725-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204725 Bug ID: 204725 Summary: |make makepatch| inserts context junk after r401709 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: regression Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: jbeich@FreeBSD.org CC: freebsd-ports-bugs@FreeBSD.org, marino@FreeBSD.org Created attachment 163394 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=163394&action=edit example junk Patch comment detection appears to be fragile and causes false positives. It doesn't break build only by accident: @@ offsets don't change, so patch(1) ignores out-of-bounds lines. For example, $ cd devel/nspr $ make clean patch makepatch $ svn diff -- You are receiving this mail because: You are on the CC list for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204725-13>