From owner-svn-src-all@FreeBSD.ORG Thu Apr 30 18:28:48 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 305E4F9A for ; Thu, 30 Apr 2015 18:28:48 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE9751C05 for ; Thu, 30 Apr 2015 18:28:47 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t3UISlAj060768 for ; Thu, 30 Apr 2015 18:28:47 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t3UISlTn060766 for svn-src-all@freebsd.org; Thu, 30 Apr 2015 18:28:47 GMT (envelope-from bdrewery) Received: (qmail 77159 invoked from network); 30 Apr 2015 13:28:45 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 30 Apr 2015 13:28:45 -0500 Message-ID: <55427462.8000504@FreeBSD.org> Date: Thu, 30 Apr 2015 13:28:50 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mariusz Zaborski , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282257 - in head: lib/libnv sys/kern sys/sys References: <201504292257.t3TMv5A1091917@svn.freebsd.org> In-Reply-To: <201504292257.t3TMv5A1091917@svn.freebsd.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="I1DeMETem9Su7PV8gVTs2vTkjrmX4h5QT" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2015 18:28:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I1DeMETem9Su7PV8gVTs2vTkjrmX4h5QT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/29/2015 5:57 PM, Mariusz Zaborski wrote: > Author: oshogbo > Date: Wed Apr 29 22:57:04 2015 > New Revision: 282257 > URL: https://svnweb.freebsd.org/changeset/base/282257 >=20 > Log: > Remove the nvlist_.*[fv] functions. > =20 > Those functions are problematic, because there is no way to report > memory allocation problems without complicating the API, so we can > either abort or potentially return invalid results. None of which is > acceptable. > =20 > In most cases the caller knows the size of the name, so he can alloca= te > buffer on the stack and use snprintf(3) to prepare the name. > =20 > After some discussion the conclusion is to removed those functions, > which also simplifies the API. > =20 > Discussed with: pjd, rstone > Approved by: pjd (mentor) >=20 > Modified: > head/lib/libnv/Makefile This breaks the ABI of libnv.so.0. You should either bump the SHLIB_MAJOR or consider making this a PRIVATELIB so it is not in the public /lib but in the private /usr/lib/private or use symbol versioning. Being in /lib we must maintain ABI compatibility among the same shlib version. Bumping the SHLIB_MAJOR or moving to PRIVATELIB will require adding the libnv.so.0 to the ObsoleteFiles.inc OLD_FILES list. --=20 Regards, Bryan Drewery --I1DeMETem9Su7PV8gVTs2vTkjrmX4h5QT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVQnRiAAoJEDXXcbtuRpfP9LEH/2b1mVdxdf6ieQtaQLM0sqH7 NvJUKLzqow+IN7Tsi46U6/6vcUxoW0DdOO6bDU3RCthNlL7QYeNgHaPoHgMj0a6H ar+DU3pEDux6bOhiioXyu2QeX5B2y+yEMjY9CLvRzuMQNY0znjSLcZUv1xbxnro+ 4HMxJi/Kt81V8Om/IGN7OYbVQBFhwfL5HgATJEI1HTZc5fgAOJQeQTbKsMSDDjl4 2HG3M/7/Ovp/4d9z7pw+4AEuYOT5kNQuAgNTh3fpHbuXLKoRSmQqZQyDX5W2hYQf AGdUcmaam7tMD+H6rxniJ2D4ZOxGAbUK20E6iPnasANHNgZY/m3ZdH0/rGvdXYc= =AVHA -----END PGP SIGNATURE----- --I1DeMETem9Su7PV8gVTs2vTkjrmX4h5QT--