From nobody Fri May 1 05:53:02 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g6Kvf2HGQz6bvCl for ; Fri, 01 May 2026 05:53:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g6Kvf1ZrFz3Qlr for ; Fri, 01 May 2026 05:53:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777614782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nXGPde0VMbm6Wxmdu5iqNniId7PmquCWY7Ywe6YZMCU=; b=TUPFYEHGsyk1PZTPMxzL+S3K/t/dE2fKab1dB8EkmHyTODYvN8LBeAKJQbxkKpcJnxps9+ mpkrhVVT7FZm7pf0vwdwe6CUWHTgBVAUo7vY34RP4j8mlGqUAGMiQFs4avENY+0/6OsaZR N+09s3Befx3vZc4ZPj9Cx4k0jXiOxEqFU7bUgHBNGa+xDRXB/8LYafPCo2WylJowfWYZp4 lN0cLcN6clYXA/qMYdD+OvHdfyfaNUTNtCTDJqs3YwzeEDgdOPxchAFI45tUOuuWfk3dGk bBS36WAFlR1WZL50y4GjlwuVRHaeNVKTjgslq4cKD63uJtXNGJeCbvTzDFz2OQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777614782; a=rsa-sha256; cv=none; b=BrHkXJFx1Riu2MQxgj/rrrsAeY/UwZwXgS9a6m5jAno5W3qijoJV62FgZV/O9c6RnoPt5V 1D6gYDSIGTZgqq9HZl2WzslMjHqmh0RBLZhgr/AmgPRsGv50++WCm3sI9t12/mMohvl+3T qsSFltOqg+ZYKHaP7Nb/JXBSkelo2C+cGztHwkcGywYyfWfgYSyClqGBdvv5Q20P617R4Y lehMqRvW0oVVHGMFZNwwBpGasNycFqXBIwm4SiL2ukiKvBFYtv4ugMpZ817WFaOnnJnhcD DKWkOZvVSg+ivzArZcFGtj+Yo1KPKFRUkWMjz0gzwwPLspYH5yTS3PTtDx6qkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777614782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nXGPde0VMbm6Wxmdu5iqNniId7PmquCWY7Ywe6YZMCU=; b=ZH/jKuXdXtGYR9hkY/iAM8U//Z8+hgbFr9ye74Wdmo3TYlEy/lvHI2kTwEP7hx6ccA0S2i r6YHKZiUJDD6kA9uz/QmvpsUgvZB7VpTrqQrwFSm2HyyDBkuVpxNB/ZH3G3cdbuU4TODYN 9C7xiAvkFxKvT1UAMmMbvU++Hn344YEJQeogXywgT8TQdVuO/nwd5dvehPOKMEZRgA7bvv 63X38B0p5XM+5g5glsgKP5+lJhXjEEYQdrKsaQHHURGFWcIhCx6exiAVbxpx1G2tEb2oLd QDNbgscQD3+gDI8bzju8ZkBmg1E4Di8ZSplIuFFBZNxzGM3fh3UPT8FyEwPIYg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g6Kvf19Jfzm4T for ; Fri, 01 May 2026 05:53:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26a88 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 01 May 2026 05:53:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Johan=?utf-8?Q? S=C3=B6llv?=ander Subject: git: 0baae6223a63 - stable/15 - ctld: normalize iSCSI TargetName on login List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: js X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 0baae6223a6350215d7b11264e59408362b15a19 Auto-Submitted: auto-generated Date: Fri, 01 May 2026 05:53:02 +0000 Message-Id: <69f43fbe.26a88.4ef1de60@gitrepo.freebsd.org> The branch stable/15 has been updated by js: URL: https://cgit.FreeBSD.org/src/commit/?id=0baae6223a6350215d7b11264e59408362b15a19 commit 0baae6223a6350215d7b11264e59408362b15a19 Author: Johan Söllvander AuthorDate: 2026-04-24 07:44:43 +0000 Commit: Johan Söllvander CommitDate: 2026-05-01 05:52:40 +0000 ctld: normalize iSCSI TargetName on login Case-insensitive TargetName matching on logins was accidentally removed, let's fix that by normalizing TargetName again according to RFC 3722. PR: 294522 Fixes: 4b1aac931465f39c5c26bfa1d5539a428d340f20 Sponsored by: ConnectWise Reviewed by: asomers, jhb Approved by: asomers (mentor) Differential Revision: https://reviews.freebsd.org/D56469 (cherry picked from commit eb837cb8b2073c09bafaf3318f5bb103827b2bca) --- usr.sbin/ctld/login.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/login.cc b/usr.sbin/ctld/login.cc index cda11cc1f21b..fb4b60c37f54 100644 --- a/usr.sbin/ctld/login.cc +++ b/usr.sbin/ctld/login.cc @@ -967,12 +967,18 @@ iscsi_connection::login() login_send_error(request, 0x02, 0x07); log_errx(1, "received Login PDU without TargetName"); } + /* + * Normalize target_name according to RFC 3722 + */ + std::string t_name(target_name); + for (char &c : t_name) + c = tolower(c); - conn_port = pg->find_port(target_name); + conn_port = pg->find_port(t_name); if (conn_port == NULL) { login_send_error(request, 0x02, 0x03); log_errx(1, "requested target \"%s\" not found", - target_name); + t_name.c_str()); } conn_target = conn_port->target(); }