From owner-svn-src-all@freebsd.org Fri Dec 29 22:50:23 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4EE1DEB47C6 for ; Fri, 29 Dec 2017 22:50:23 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D2B5B7F5A2 for ; Fri, 29 Dec 2017 22:50:22 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x22a.google.com with SMTP id g75so50486592wme.0 for ; Fri, 29 Dec 2017 14:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bUr4zIgRGMLGrUCaRSNK51fFoCtB2sf6egU9DNgNqRM=; b=XCQ/Is+7T+MhgB68LssLRfjncwfSDRYDgSu5ZmEqfvi/uvtl4C9DFM6q1gihTK++Zm OgWDQ87IOIsY8OqhbeGQPODVaPqgeD9EeMgzk2Iackv0T56aLKt9VIKWIZU+wt0Q9H8O 8G93kJzGgjC5mpsCBsmpVTxAjF+3YFrZLI2OSWOPeMTdtDpV/wEBm0ST3sg/g+Sr9+hm kcGQafctYMXSOpig3FZhLTiIdMyNg+7TpcJrAiecPjdvG9XSt/5kNPfR8zwe84wJ1f93 RqsW+zBl3WIayUoj7CkW4Ye62WVJGueZ7aRV2CZaWnL54I6SdGABSRIGp6huM+iyDC/z lSpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bUr4zIgRGMLGrUCaRSNK51fFoCtB2sf6egU9DNgNqRM=; b=C5T627fCr4oj/vjSYoub2cIpdhQG7Lc5A3fBMULRim/CDtxjNTpx7buaSJKtfpbrI0 YlTUrdjWMQZUeTy+Ne/s0BNP5f1kWD98w39DwUHxtqCblqB2dLdhAEGmRdV1LDvP35JT 6b90EtqZIb1TMViXGhbziiJ5g2iXv+c4a+boKMslxTQwpxalm/v0N+TEYdfZ4SS7r5+V Ugnv/WC/Y4Csk3z5yT4uMgsw1diMszeNXsyi1T3DPwG1yAiHtxdggq2/4o2RVhbEgroN p0eOx1wpQBj/K39kVCvknX7doTUugxG1KEX0pcYBRET/16ikdbXhtK6wx5sjjzO6iQ9d hzXQ== X-Gm-Message-State: AKGB3mKaSVVX6VXTuksPJ7i1oJzvMMlnzNuwcYszepU6MdWxdWCNM6ah CaY+X5jOaWvklnJG1iFc2FkedIcSTUKqJr/uo1rCjw== X-Google-Smtp-Source: ACJfBos3jlKalp6eQ3AM/6giqmr8LibMGASwNoGMRxrE1ftkNTyWFITMnFm/RSBGaPL/RKMPnwjWA5s6mxckg+BTO2M= X-Received: by 10.80.142.88 with SMTP id 24mr47732215edx.153.1514587821335; Fri, 29 Dec 2017 14:50:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.149.174 with HTTP; Fri, 29 Dec 2017 14:50:21 -0800 (PST) In-Reply-To: References: <201712292208.vBTM8hpG048007@repo.freebsd.org> From: Oliver Pinter Date: Fri, 29 Dec 2017 23:50:21 +0100 Message-ID: Subject: Re: svn commit: r327362 - in head/usr.bin/find: . tests To: "cem@freebsd.org" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Dec 2017 22:50:23 -0000 On Friday, December 29, 2017, Conrad Meyer wrote: > On Fri, Dec 29, 2017 at 2:41 PM, Oliver Pinter > wrote: > > Why did you comment out these tests? > > I think unit tests are a good idea for this kind of change, which is > why I wrote them. And I run them before commit. But I'm not > interested in tilting at the test build infrastructure to actually > enable them. Someone else can hook them up to the build if they want > to. Okay. That's fine. Thanks for the clarification. > > Conrad >