From owner-svn-src-head@freebsd.org Sun Oct 16 19:48:19 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76897C12608; Sun, 16 Oct 2016 19:48:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x244.google.com (mail-pa0-x244.google.com [IPv6:2607:f8b0:400e:c03::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46D8D1227; Sun, 16 Oct 2016 19:48:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pa0-x244.google.com with SMTP id hh10so8424401pac.0; Sun, 16 Oct 2016 12:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=I0tuZTVa5R5k/mZFyQBdAZ3rb17COaZzdeeDZFnw+Uc=; b=XlS6lKFctu44/dsQMjTghBUr0/9p5sCfH6BkGRBpff+q/jQrzQ8yrWjzzsQT4mfsET 2LenqHmf4BK2tepxL+ihokv1S2ZUo8OWATFMR/348RYkYfidfMGNUsRvvJ6/jra7ZGW/ dS6+J6rvTN7sF7X400jhtQBlM8LXh9GAUkE5CnVE+KvZOGSQdeBXRJrOcNKr+p1r7BYx d3AZXHJoG6fMxkvUC5MFus+mSTIz85hRjZhnCW9Su+kK9ju9ceooom00bGNUYYqxUIvq h6SRctyXu4SCmT7aQGxgk9oo/aUsoCbpYSwNJftndMA71uYfTJ5lGZFqJ/MDnkOFOZ2i 742w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=I0tuZTVa5R5k/mZFyQBdAZ3rb17COaZzdeeDZFnw+Uc=; b=ZW1G7cXAtlRq//RsvDQV4gooA7yoxzKo+TEFfQSDDI7Wodt0IPaLhhTFyBCf5yi73X LUXwRES0/YRlGTO/kRUdYXVKQ48Oe3jfaas+HRiz6OhVGb0LTQBfwwTC3wlHtub09Xn9 jj1Mi1L7fmdpd9lV4Zv2jT5cksLROCv22mV4n7rK6dtUp9kfMcUDH9mBzJ0QoxHRkq8K ez/BLJuDkFV7x8twTWoYn2NCZ8H6XdW5jEu/kQYLybI1V2Xmsjae1AMlRCwP+IxBKPGi f0ySmEuENLa0dNOY+uODx67pJG/RTopO0OJLkQ9H9LU++vGhTTStmorRobtjEvR5Wfhq Pn7A== X-Gm-Message-State: AA6/9RmVXUg7OeGpQ83SGwWi6UG/8gUHRCb12QsWhkoudsHbUxQt/Y++uJV8M2JCdcYUcQ== X-Received: by 10.66.15.134 with SMTP id x6mr27595157pac.171.1476647298669; Sun, 16 Oct 2016 12:48:18 -0700 (PDT) Received: from [192.168.20.13] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id k67sm42293124pfb.86.2016.10.16.12.48.17 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 16 Oct 2016 12:48:18 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r307397 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Ngie Cooper X-Mailer: iPhone Mail (14A456) In-Reply-To: <201610161849.u9GInFiY016740@repo.freebsd.org> Date: Sun, 16 Oct 2016 12:48:17 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201610161849.u9GInFiY016740@repo.freebsd.org> To: Alexander Motin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2016 19:48:19 -0000 > On Oct 16, 2016, at 11:49, Alexander Motin wrote: >=20 > Author: mav > Date: Sun Oct 16 18:49:15 2016 > New Revision: 307397 > URL: https://svnweb.freebsd.org/changeset/base/307397 >=20 > Log: > Add vfs.zfs.zil_log_limit sysctl. >=20 > It is at least partially broken now, but that is another question. How is it broken? > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c >=20 > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c Sun Oct 1= 6 18:27:41 2016 (r307396) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c Sun Oct 1= 6 18:49:15 2016 (r307397) > @@ -924,6 +924,8 @@ uint64_t zil_block_buckets[] =3D { > * Limit checking is disabled by setting zil_slog_limit to UINT64_MAX. > */ > uint64_t zil_slog_limit =3D 1024 * 1024; > +SYSCTL_QUAD(_vfs_zfs, OID_AUTO, zil_slog_limit, CTLFLAG_RWTUN, > + &zil_slog_limit, 0, "Maximal commit size to use SLOG"); > #define USE_SLOG(zilog) (((zilog)->zl_logbias =3D=3D ZFS_LOGBIAS_LATENC= Y) && \ > (((zilog)->zl_cur_used < zil_slog_limit) || \ > ((zilog)->zl_itx_list_sz < (zil_slog_limit << 1)))) >=20