From owner-freebsd-hackers Sun Mar 23 21:51:00 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA28850 for hackers-outgoing; Sun, 23 Mar 1997 21:51:00 -0800 (PST) Received: from dg-rtp.dg.com (dg-rtp.rtp.dg.com [128.222.1.2]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id VAA28820 for ; Sun, 23 Mar 1997 21:50:51 -0800 (PST) Received: by dg-rtp.dg.com (5.4R3.10/dg-rtp-v02) id AA11404; Mon, 24 Mar 1997 00:50:04 -0500 Received: from ponds by dg-rtp.dg.com.rtp.dg.com; Mon, 24 Mar 1997 00:50 EST Received: from lakes.water.net (lakes [10.0.0.3]) by ponds.water.net (8.8.3/8.7.3) with ESMTP id SAA03703; Sun, 23 Mar 1997 18:39:22 -0500 (EST) Received: (from rivers@localhost) by lakes.water.net (8.8.3/8.6.9) id SAA13564; Sun, 23 Mar 1997 18:44:55 -0500 (EST) Date: Sun, 23 Mar 1997 18:44:55 -0500 (EST) From: Thomas David Rivers Message-Id: <199703232344.SAA13564@lakes.water.net> To: joerg_wunsch@uriah.heep.sax.de Subject: Re: More "dup alloc" info. Cc: ponds!freefall.cdrom.com!freebsd-hackers Content-Type: text Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > As Thomas David Rivers wrote: > > > However, using: > > if(cpl & bio_imask != bio_imask) > > checks in some suspect places (i.e. scsi_done(), biodone()) I haven't > > been able to verify this. (That is, none of them were tripped.) > > I hope you wrote it as > > if ((cpl & bio_imask) != bio_imask) > ... > > Otherwise, bio_imask is always equal bio_imask, and will be optimized > away by the compiler, so the entire condition always evaluates to > false. Well - look at me; manager of a C compiler group and I can't even get that right!!! In the words of Homer Simpson - Doh. [Hmmm... maybe I've been in management too long...] I'm *really* glad you pointed that out, and I feel really stupid :-) I'll try these all over again... - Thanks - - Dave Rivers -