From owner-svn-src-all@FreeBSD.ORG Fri Jun 1 16:40:20 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3FA981065673 for ; Fri, 1 Jun 2012 16:40:20 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id E7F138FC1B for ; Fri, 1 Jun 2012 16:40:19 +0000 (UTC) Received: by obcni5 with SMTP id ni5so3996613obc.13 for ; Fri, 01 Jun 2012 09:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=1CyF+Xu5T4tst7j6hWiAYLUB/1KqlPyEoRf8aQ90+nQ=; b=qmtAMXAN9/hlVNEl5XeKSTqHGu5jnq7XYHW/u7/4tcSklZ9J5rDBcyE9r5ULdXP5l2 H+2KJw8YBzEjzdaD7UJxrEqgS83wSnW9dONRquCHdpWFx+Q6zejKFX4Et5zqzu+djfLD AxmzlSCj3UMXvnKVYfAIdoJgPu/ZFfwycWtIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=1CyF+Xu5T4tst7j6hWiAYLUB/1KqlPyEoRf8aQ90+nQ=; b=DNobQa2R6IDBlDdWsW4tZjOgruRA6Lkvf3TlXYECg52tdRv4XTbh4wspfVKqOOQXLH WuogB99SPgQjleaZj5IG+oLErqlQpY03aGTJTwKef4OlmD7MVa/PFPSBuUgu6OEDRqSD 08GN0jH3PWN2x+CvJZQGvoRYQpxuXj6OcEwhPaXbJMq6hWVSh4riskw1arf5eWgAmna7 bJSRhccKr6LuFND9M0+bjYGZ+Ov1klFpjUouU8EuXKGLPzVIEJmLysOP0OLYwafrTbkl pSTRXDla9Yr3ntwwYlssm5XyIcNQCVoBNOLTgsYIUQkEyrxvBGN/S5en8B63mWnFlEc3 I9rA== Received: by 10.182.187.42 with SMTP id fp10mr3384137obc.30.1338568819232; Fri, 01 Jun 2012 09:40:19 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.182.204.69 with HTTP; Fri, 1 Jun 2012 09:39:48 -0700 (PDT) In-Reply-To: <201206011024.49122.jhb@freebsd.org> References: <201206010423.q514NKtf083043@svn.freebsd.org> <20120601150242.V1226@besplex.bde.org> <201206011024.49122.jhb@freebsd.org> From: Eitan Adler Date: Fri, 1 Jun 2012 09:39:48 -0700 X-Google-Sender-Auth: E5gQKGmPsjxQUHVQae9WAybZAQ0 Message-ID: To: John Baldwin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQnBG/jJkfCVNUIu8cfYZyF2936YxuElBBkvxR/aHYnHvvnUi/OaVTSMW4a9+p+/e5Fvbd74 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans Subject: Re: svn commit: r236377 - head/sys/dev/vxge/vxgehal X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2012 16:40:20 -0000 On 1 June 2012 07:24, John Baldwin wrote: > This is why I personally loathe assignment side effects in boolean expres= sions > for control flow. =C2=A0I tend to write this sort of thing instead as: > > =C2=A0 =C2=A0 =C2=A0 =C2=A0channel->dtr_arr[dtr_index].dtr =3D dtrh; > =C2=A0 =C2=A0 =C2=A0 =C2=A0if (dtrh !=3D NULL) { Same here. I was told to use the assignment is style(9) by multiple people though. If it really is, I wish it would change. --=20 Eitan Adler Source & Ports committer X11, Bugbusting teams