From owner-freebsd-hackers@FreeBSD.ORG Fri Feb 11 12:56:55 2011 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE72C106564A; Fri, 11 Feb 2011 12:56:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 7D8958FC13; Fri, 11 Feb 2011 12:56:55 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 28DC546B06; Fri, 11 Feb 2011 07:56:55 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.10]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4D33F8A01D; Fri, 11 Feb 2011 07:56:54 -0500 (EST) From: John Baldwin To: freebsd-hackers@freebsd.org Date: Fri, 11 Feb 2011 07:51:52 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <20110211103028.12684f54yrw8tgqo@webmail.leidinger.net> In-Reply-To: <20110211103028.12684f54yrw8tgqo@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102110751.52863.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 11 Feb 2011 07:56:54 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=0.5 required=4.2 tests=BAYES_00,MAY_BE_FORGED, RDNS_DYNAMIC autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Alexander Leidinger , hackers@freebsd.org, kibab@freebsd.org Subject: Re: CFR: FEATURE macros for AUDIT/CAM/IPC/KTR/MAC/NFS/NTP/PMC/SYSV/... X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2011 12:56:55 -0000 On Friday, February 11, 2011 4:30:28 am Alexander Leidinger wrote: > Hi, > > during the last GSoC various FEATURE macros where added to the system. > Before committing them, I would like to get some review (like if macro > is in the correct file, and for those FEATURES where the description > was not taken from NOTES if the description is OK). > > If nobody complains, I would like to commit this in 1-2 weeks. If you > need more time to review, just tell me. > > Here is the list of affected files (for those impatient ones which do > not want to look at the attached patch before noticing that they are > not interested to look at it): Hmm, so what is the rationale for adding FEATURE() macros? Do we just want to add them for everything or do we want to add them on-demand as use cases for each knob arrive? Some features can already be inferred (e.g. if KTR is compiled in, then the debug.ktr.mask sysctl will exist). Also, in the case of KTR, I'm not sure that any userland programs need to alter their behavior based on whether or not that feature was present. -- John Baldwin