From owner-svn-src-all@freebsd.org Mon Oct 1 15:48:06 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B97210C1CEB; Mon, 1 Oct 2018 15:48:06 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D774D7C7DC; Mon, 1 Oct 2018 15:48:05 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f181.google.com with SMTP id p6-v6so12635638ljc.5; Mon, 01 Oct 2018 08:48:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MfRwL6FreR5qDOXQIXlDyLb5khd0FCMV2+n4ptBVNUk=; b=gQ86qSEWkELif1kC5qoaKmmpyfvbc+VgqmEtd9VArHZZ9/mbq+xXyNnfX6EOVU4C5s +TXco59G1uHzgXAuhlejoCwf1BDe9QJAuiZHwudai/Jc+V223rEreJFYlJNk6Q0/7Pih aMU33vwH9AEHsTKNq+jHemWxv4ZfIrIWWcoWDQK0mPhiFMrsolrzDx7Y+q9S8sOavJYP 3WX7L/j8fbvTTLnXbnxNCiIN5IyanMuYyt8/U6jMAv0yhiGwdL34b/I1xujNI/Tcr8VQ bKQFpimkUdZY6Q5yQXqjAYIpYfRt1lOft07AdVisBHZp4pES+vNaqSAHloTJLOcPc1zI pXZw== X-Gm-Message-State: ABuFfogBjW2EOysYcn66ILKouo1EQHGuxinKRZDr5+EYTknPErPo+bXq cOMjo4PH+pNbMju6uhEdZXSa4OTFPga5IlU22CZHbQ== X-Google-Smtp-Source: ACcGV608YeeLArnkM5mMmqbKpz7kJTqVHaIG/yhZfcJvCrt0n/dTlEtLdocL+3A1QI/f40Ouj7KDELMUcdv2VqtatTQ= X-Received: by 2002:a2e:9448:: with SMTP id o8-v6mr6865134ljh.34.1538408554284; Mon, 01 Oct 2018 08:42:34 -0700 (PDT) MIME-Version: 1.0 References: <201806231820.w5NIKHaS051052@repo.freebsd.org> In-Reply-To: <201806231820.w5NIKHaS051052@repo.freebsd.org> From: Alan Somers Date: Mon, 1 Oct 2018 09:42:22 -0600 Message-ID: Subject: Re: svn commit: r335584 - head/sys/crypto/aesni To: "Conrad E. Meyer" Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 15:48:06 -0000 On Sat, Jun 23, 2018 at 12:20 PM Conrad Meyer wrote: > Author: cem > Date: Sat Jun 23 18:20:17 2018 > New Revision: 335584 > URL: https://svnweb.freebsd.org/changeset/base/335584 > > Log: > aesni(4): Fix {de,en}crypt operations that allocated a buffer > > aesni(4) allocates a contiguous buffer for the data it processes if the > provided input was not already virtually contiguous, and copies the input > there. It performs encryption or decryption in-place. > > r324037 removed the logic that then copied the processed data back to the > user-provided input buffer, breaking {de,enc}crypt for mbuf chains or > iovecs with more than a single descriptor. > > PR: 228094 (probably, not confirmed) > Submitted by: Sean Fagan > Reported by: Emeric POUPON > X-MFC-With: 324037 > Security: could result in plaintext being output by "encrypt" > operation > > Modified: > head/sys/crypto/aesni/aesni.c > Can we MFC this now?