From owner-cvs-src@FreeBSD.ORG Sun Oct 31 05:06:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id E216716A4CE; Sun, 31 Oct 2004 05:06:22 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9V56M9K095788; Sun, 31 Oct 2004 01:06:22 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i9V56Lfa095787; Sun, 31 Oct 2004 01:06:21 -0400 (EDT) (envelope-from green) Date: Sun, 31 Oct 2004 01:06:20 -0400 From: Brian Fundakowski Feldman To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041031050620.GQ93831@green.homeunix.org> References: <200410310503.i9V53ofj011896@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410310503.i9V53ofj011896@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 05:06:23 -0000 On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > green 2004-10-31 05:03:50 UTC > > FreeBSD src repository > > Modified files: > lib/libpthread/thread thr_mutex.c > Log: > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > packages expect and seems to be most correct according to the slightly- > ambiguous standards. > > MFC after: 1 month > Corroborated by: POSIX > Reviewed by: silence on threads@ Software such as mozilla projects (using NSPR) and Java have been broken in various ways by this. We need to try to be more compatible with the most popular interpretation of the standards (instead of just inventing our own) -- usually we're pretty good about this. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\