From owner-cvs-all Fri Nov 22 15:17:21 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14A5137B401; Fri, 22 Nov 2002 15:17:19 -0800 (PST) Received: from topaz.mdcc.cx (topaz.mdcc.cx [212.204.230.141]) by mx1.FreeBSD.org (Postfix) with ESMTP id 324FA43E4A; Fri, 22 Nov 2002 15:17:18 -0800 (PST) (envelope-from edwin@mavetju.org) Received: from k7.mavetju (topaz.mdcc.cx [212.204.230.141]) by topaz.mdcc.cx (Postfix) with ESMTP id 988392B67D; Sat, 23 Nov 2002 00:17:07 +0100 (CET) Received: by k7.mavetju (Postfix, from userid 1001) id 6B9BD6A712B; Sat, 23 Nov 2002 10:17:04 +1100 (EST) Date: Sat, 23 Nov 2002 10:17:04 +1100 From: Edwin Groothuis To: Dan Langille Cc: lioux@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, ports@FreeBSD.org Subject: Re: spaces in RUN_DEPENDS and BUILD_DEPENDS Message-ID: <20021122231704.GJ50581@k7.mavetju> References: <20021122082819.G3909-100000@m20.unixathome.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021122082819.G3909-100000@m20.unixathome.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Nov 22, 2002 at 08:49:50AM -0500, Dan Langille wrote: > Following up on 20021121230418.6004.qmail@exxodus.fedaykin.here, I have > compiled a list of the ports which contains either trailing spaces, > leading spaces, or multiple embedded spaces within either the RUN_DEPENDS > or BUILD_DEPENDS output. We have yet to establish whether or not this is > actually a problem, but the list of such ports (with maintainer and > RUN_DEPENDS, BUILD_DEPENDS) is at > http://www.freshports.org/tmp/ports_spaces_depends.tgz (the file is about > 62KB, the uncompressed file is about 3.5MB). Approximately 900 ports are > affected. > > I have summarized the totals below as taken from a FreshPorts database > backup from yesterday. There will be overlap between each query as ports > may exhibit multiple symptoms. Err... there is a thinking in error in this: it takes both the values from the ports Makefile and the one added by the ports-framework. For example, look at archivers/fileroller: Your database contains: RUN_DEPENDS: bzip:/usr/ports/archivers/bzip lha:/usr/ports/archivers/lha rar:/usr/ports/archivers/rar lzop:/usr/ports/archivers/lzop Looking at the Makefile (last modified 2002/11/13), I see this: RUN_DEPENDS= bzip:${PORTSDIR}/archivers/bzip \ lha:${PORTSDIR}/archivers/lha \ rar:${PORTSDIR}/archivers/rar \ lzop:${PORTSDIR}/archivers/lzop make -V RUN_DEPENDS outputs this to: bzip:/usr/ports/archivers/bzip lha:/usr/ports/archivers/lha rar:/usr/ports/archivers/rar lzop:/usr/ports/archivers/lzop /usr/X11R6/share/gnome/.keep_me:/usr/ports/misc/gnomehier There are your double spaces, which weren't originally in the Makefile. Further more, BUILD_DEPENDS is often extended by the framework, if you add USE_GMAKE=yes or USE_REINPLACE=yes: gmake:/usr/ports/devel/gmake /usr/local/bin/sed_inplace:/usr/ports/textproc/s ed_inplace The port itself can't do anything about this, but still will get complained about. Just my 2 cents regarding the data. Edwin -- Edwin Groothuis | Personal website: http://www.MavEtJu.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/weblog.php bash$ :(){ :|:&};: | Interested in MUDs? http://www.FatalDimensions.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message