From owner-cvs-src@FreeBSD.ORG  Mon Oct 10 09:06:53 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2ADE616A41F;
	Mon, 10 Oct 2005 09:06:53 +0000 (GMT) (envelope-from sos@FreeBSD.org)
Received: from spider.deepcore.dk
	(cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk
	[80.166.201.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8610943D45;
	Mon, 10 Oct 2005 09:06:52 +0000 (GMT) (envelope-from sos@FreeBSD.org)
Received: from [194.192.25.136] (mac.deepcore.dk [194.192.25.136])
	by spider.deepcore.dk (8.13.4/8.13.3) with ESMTP id j9A95ioS096210;
	Mon, 10 Oct 2005 11:05:44 +0200 (CEST)
	(envelope-from sos@FreeBSD.org)
In-Reply-To: <200510092111.j99LB5gN037609@repoman.freebsd.org>
References: <200510092111.j99LB5gN037609@repoman.freebsd.org>
Mime-Version: 1.0 (Apple Message framework v734)
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Message-Id: <D29978F6-7AD7-4EF8-8A7F-12F7EE533845@FreeBSD.org>
Content-Transfer-Encoding: quoted-printable
From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org>
Date: Mon, 10 Oct 2005 11:06:49 +0200
To: Peter Edwards <peadar@FreeBSD.org>
X-Mailer: Apple Mail (2.734)
X-mail-scanned: by DeepCore Virus & Spam killer v1.12
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2005 09:06:53 -0000

On 09/10/2005, at 23:11, Peter Edwards wrote:

Why did you ask me to review this when you just committed it anyway ?

As I said I'm not sure this is the right way to fix this..

So, this means *you* are now the maintainer of atapi-cd,c ?!

-S=F8ren

> peadar      2005-10-09 21:11:05 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/ata          atapi-cd.c
>   Log:
>   When breaking up a large request into smaller ones for the strategy
>   routine, create all the child bio objects before starting the
>   requests, rather than starting them as created. This closes a race
>   whereby some number of child operations could complete before the
>   rest were ever created, and prematurely freeing the parent bio.
>   This fixes the panics installing in VMWare and qemu
>
>   Revision  Changes    Path
>   1.181     +7 -1      src/sys/dev/ata/atapi-cd.c
>
>