From nobody Tue Nov 2 12:14:53 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7E4331828ABB; Tue, 2 Nov 2021 12:14:56 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hk83h35w9z3PP9; Tue, 2 Nov 2021 12:14:56 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from [172.21.4.113] (dynamic-177-53-82-16.telecominternet.net.br [177.53.82.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id A321A27FD; Tue, 2 Nov 2021 12:14:55 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: <04932e68-9e69-67b2-4be9-beb379bec130@FreeBSD.org> Date: Tue, 2 Nov 2021 09:14:53 -0300 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: git: 67be9a912d61 - main - devel/git: Update to 2.33.1 Content-Language: en-US To: Yasuhiro Kimura Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202110300623.19U6NOPO023944@gitrepo.freebsd.org> <1e6ee54f-7917-49dc-ae65-44d4f5e71291@FreeBSD.org> <20211102.023703.1883557663869848680.yasu@FreeBSD.org> From: Renato Botelho In-Reply-To: <20211102.023703.1883557663869848680.yasu@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 01/11/21 14:37, Yasuhiro Kimura wrote: > Hello Renato. > > From: Renato Botelho > Subject: Re: git: 67be9a912d61 - main - devel/git: Update to 2.33.1 > Date: Mon, 1 Nov 2021 11:55:24 -0300 > >> Yasuhiro, >> >> Thanks for pushing the upgrade. One small note, when HTMLDOCS option >> is set, it installs a small txt file with notes for each version. The >> patch you pushed is missing one pkg-plist entry for that: >> >> %%HTMLDOCS%%%%DOCSDIR%%/RelNotes/2.33.1.txt > > Thank you for reporting it. And sorry for breackage. I pushed the fix. Thanks! > But at the same time another problem is found. Before submitting > update to 2.33.1, I did poudriere build test with HTMLDOCS is ON. And > poudriere didn't report any error at check-plist stage. So I removed > all lines starting with '%%HTMLDOCS%%' from pkg-plist and did test > build again. Then check-plist didn't report any error either. > > That is, `make check-plist` doesn't report any plist error about files > installed when HTMLDOCS is enabled. It doesn't happen with other > options. For example if I removes line starting with '%%CURL%%', then > `make check-plist` detects plist error successfully. > > Though I'm not sure exactly when, I remember plist error related to > HTMLDOCS option was successfully detected when I created patch to > updated the port previously. So it's very strange that only plist > error related to HTMLDOCS become undetected. Yes, it should detect installed items that are not part of PLIST. I'm going to take a look at it. -- Renato Botelho