Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 Dec 2023 01:07:42 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Rene Ladan <rene@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 3eadab0ea3ae - main - games/tomenet: unbreak the port, undeprecate, respect CFLAGS better.
Message-ID:  <ZZC-3jyCoEuTZiBH@FreeBSD.org>
In-Reply-To: <ZZBZ4MOO0RrucNn3@freefall.freebsd.org>
References:  <202312301444.3BUEiIx5051540@gitrepo.freebsd.org> <ZZBZ4MOO0RrucNn3@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 30, 2023 at 05:56:48PM +0000, Rene Ladan wrote:
> On Sat, Dec 30, 2023 at 02:44:18PM +0000, Alexey Dokuchaev wrote:
> > commit 3eadab0ea3ae60cde9ffaa21c0caa71f48563827
> > 
> >   games/tomenet: unbreak the port, undeprecate, respect CFLAGS better.
> > ---
> > -DEPRECATED=	BROKEN for more than 2 years on all supported versions after the EOL of 12
> > -EXPIRATION_DATE=	2023-12-31
> > -BROKEN_FreeBSD_13=	ld: error: duplicate symbol: lite_later
> > -BROKEN_FreeBSD_14=	ld: error: duplicate symbol: lite_later
> 
> And there was no time in the past two years for you to fix this
> port before?

I was one of several who helped to fix initial bulk of broken ports
after -fno-common was enforced, this one probably slipped through
the cracks, but better late than never, no? :)

The real question one should be asking, however, is why mark these
ports BROKEN in the first place rather than fix them right away.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZZC-3jyCoEuTZiBH>