From owner-freebsd-audit  Mon Nov 25  4:57:20 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 725B637B401
	for <freebsd-audit@FreeBSD.ORG>; Mon, 25 Nov 2002 04:57:19 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 72F8143E91
	for <freebsd-audit@FreeBSD.ORG>; Mon, 25 Nov 2002 04:57:18 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA11958;
	Mon, 25 Nov 2002 23:56:56 +1100
Date: Tue, 26 Nov 2002 00:10:20 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Olivier Houchard <cognet@ci0.org>
Cc: freebsd-audit@FreeBSD.ORG
Subject: Re: do_dup patch
In-Reply-To: <20021125121747.GA11569@ci0.org>
Message-ID: <20021126000957.B430-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Mon, 25 Nov 2002, Olivier Houchard wrote:

> On Mon, Nov 25, 2002 at 11:07:53PM +1100, Bruce Evans wrote:
> > %%%
> > Index: kern_descrip.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v
> > retrieving revision 1.168
> > diff -u -2 -r1.168 kern_descrip.c
> > --- kern_descrip.c	27 Oct 2002 18:07:41 -0000	1.168
> > +++ kern_descrip.c	25 Nov 2002 11:56:27 -0000
> > @@ -471,6 +475,6 @@
> >  	 */
> >  	FILEDESC_LOCK(fdp);
> > -	if (old >= fdp->fd_nfiles || fdp->fd_ofiles[old] == NULL ||
> > -	    new >= p->p_rlimit[RLIMIT_NOFILE].rlim_cur ||
> > +	if (old < 0 || old >= fdp->fd_nfiles || fdp->fd_ofiles[old] == NULL ||
> > +	    new < 0 || new >= p->p_rlimit[RLIMIT_NOFILE].rlim_cur ||
> >  	    new >= maxfilesperproc) {
> >  		FILEDESC_UNLOCK(fdp);
> > %%%
>
> I just tested the same change and it is ok.
> Shall I submit it to re@ or will you do it ?

Please do it.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message