From owner-freebsd-net@FreeBSD.ORG  Sun Dec 28 23:30:59 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8ED561065793;
	Sun, 28 Dec 2008 23:30:59 +0000 (UTC)
	(envelope-from mat.macy@gmail.com)
Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.235])
	by mx1.freebsd.org (Postfix) with ESMTP id 5CB958FC14;
	Sun, 28 Dec 2008 23:30:59 +0000 (UTC)
	(envelope-from mat.macy@gmail.com)
Received: by rv-out-0506.google.com with SMTP id b25so5736505rvf.43
	for <multiple recipients>; Sun, 28 Dec 2008 15:30:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:sender
	:to:subject:cc:in-reply-to:mime-version:content-type
	:content-transfer-encoding:content-disposition:references
	:x-google-sender-auth;
	bh=iQvH7Vjb0wvTEoTQhtU9HV6gzD6N6CZd/fAiLpEu1qM=;
	b=LVa9ZoJVjIwGLCo83h/rFiaMqqcKFZq/XR9WlsP8IPXw23rlMb0IMbrGZgSMDYN6RY
	cqxjiWLhwxWFsgHH3F3I9nue8T8hLFzcv1kg+M+sADuadvKYvKl8tIwqS1blH7+xrF3W
	1RtT4tp09gWUqVBxh+NzrWAGIZV3d++9f0GZc=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
	:content-type:content-transfer-encoding:content-disposition
	:references:x-google-sender-auth;
	b=FMllzoDGVvoX+DNxyD67/65UNoa+XqnWimqaoNl0QZjhLJcoFebArxnBEcT+KfJ+a4
	5lafFboKdsGHh9nbWKujtNTHTW+scIohczBK9rsfFX3FE5KGA0O8ZhYIEpnoA2A0ZAFR
	LGCPPBcdZOjyBNVKCfSeJ9S9wTXV9aKS3OIKQ=
Received: by 10.141.100.15 with SMTP id c15mr6423503rvm.222.1230507059096;
	Sun, 28 Dec 2008 15:30:59 -0800 (PST)
Received: by 10.141.37.17 with HTTP; Sun, 28 Dec 2008 15:30:59 -0800 (PST)
Message-ID: <3c1674c90812281530l52b83404k9822cf6818329f01@mail.gmail.com>
Date: Sun, 28 Dec 2008 15:30:59 -0800
From: "Kip Macy" <kmacy@freebsd.org>
Sender: mat.macy@gmail.com
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
In-Reply-To: <20081228225956.G28465@maildrop.int.zabbadoz.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081228225956.G28465@maildrop.int.zabbadoz.net>
X-Google-Sender-Auth: d797649d93439105
Cc: Qing Li <qingli@freebsd.org>, freebsd-net@freebsd.org
Subject: Re: arp-v2 (void *)-1 "hack"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2008 23:30:59 -0000

> What do you think wrt to adding the (possibly optional) int *error and
> returning the errno rather than a (void *)-1?  If you'd be ok, I'd can
> prepare the patch. I'd rather break the API now than in a few months.

I would greatly prefer having a dedicated new function that calls in
to it. There are a lot of calls to lla_lookup that would have to be
changed needlessly. In other words:
1) lla_lookup_internal - a static function which takes all 3 args
2) lla_delete - which returns an errno
3) lla_lookup - which maintains the current interface

I'll review the patch as soon as it is ready.

-Kip