From owner-cvs-all@FreeBSD.ORG  Fri Dec  3 16:19:19 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 71CB416A4CE; Fri,  3 Dec 2004 16:19:19 +0000 (GMT)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2724243D2F; Fri,  3 Dec 2004 16:19:19 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.1.4] ([63.126.101.90])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id iB3GJGC5019373
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Fri, 3 Dec 2004 08:19:18 -0800
Message-ID: <41B091E8.2060807@root.org>
Date: Fri, 03 Dec 2004 08:18:48 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040901)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@FreeBSD.org>
References: <20041203120940.5573116A515@hub.freebsd.org>
In-Reply-To: <20041203120940.5573116A515@hub.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_subr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Dec 2004 16:19:19 -0000

Poul-Henning Kamp wrote:
> phk         2004-12-03 12:09:34 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             vfs_subr.c 
>   Log:
>   Improve vprint() a little bit:  break long lines, reduce indent and tell
>   if the VI_LOCK() is held.
>   
>   Revision  Changes    Path
>   1.555     +7 -4      src/sys/kern/vfs_subr.c
> 
> 
> --- src/sys/kern/vfs_subr.c:1.554	Wed Dec  1 23:16:36 2004
> +++ src/sys/kern/vfs_subr.c	Fri Dec  3 12:09:34 2004
> @@ -2651,9 +2651,9 @@
>  		printf("%s: %p: ", label, (void *)vp);
>  	else
>  		printf("%p: ", (void *)vp);
> -	printf("tag %s, type %s, usecount %d, writecount %d, refcount %d,",
> -	    vp->v_tag, typename[vp->v_type], vp->v_usecount,
> -	    vp->v_writecount, vp->v_holdcnt);
> +	printf("tag %s, type %s\n    ", vp->v_tag, typename[vp->v_type]);
> +	printf("usecount %d, writecount %d, refcount %d mountedhere %p\n",
> +	    vp->v_usecount, vp->v_writecount, vp->v_holdcnt, vp->v_mountedhere);
>  	buf[0] = '\0';
>  	if (vp->v_vflag & VV_ROOT)
>  		strcat(buf, "|VV_ROOT");
> @@ -2672,7 +2672,10 @@
>  	if (vp->v_vflag & VV_OBJBUF)
>  		strcat(buf, "|VV_OBJBUF");
>  	if (buf[0] != '\0')
> -		printf(" flags (%s),", &buf[1]);
> +		printf("    flags (%s)", &buf[1]);
> +	if (mtx_owned(VI_MTX(vp)))
> +		printf(" VI_LOCKed");
> +	printf("\n    ");
>  	lockmgr_printinfo(vp->v_vnlock);
>  	printf("\n");
>  	if (vp->v_data != NULL)

I think that breaking vprint() into multiple lines is not a good idea. 
Bruce pointed this out to me when I was doing the v_tag changes a while ago.

-Nate