From owner-svn-src-all@freebsd.org  Thu Feb 14 20:42:31 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E55F14E103F;
 Thu, 14 Feb 2019 20:42:31 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 891C58B024;
 Thu, 14 Feb 2019 20:42:30 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1EKgSxZ087718;
 Thu, 14 Feb 2019 12:42:28 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1EKgSwf087717;
 Thu, 14 Feb 2019 12:42:28 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r344129 - head
In-Reply-To: <20190214191329.GB50900@raichu>
To: Mark Johnston <markj@freebsd.org>
Date: Thu, 14 Feb 2019 12:42:28 -0800 (PST)
CC: Warner Losh <imp@bsdimp.com>, "Rodney W. Grimes" <rgrimes@freebsd.org>,
 Warner Losh <imp@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 891C58B024
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.96 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 NEURAL_HAM_SHORT(-0.96)[-0.961,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Feb 2019 20:42:31 -0000

> On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote:
> > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes <
> > > >   Differential Review: https://reviews.freebsd.org/D19193
> > >
> > > You sited a differential, but not give any attribution
> > > to the external source :-(
> > >
> > 
> > The differential review has that information.
> 
> External contributors should be recognized by having their names appear
> in the commit logs.

We even bother to put a special line in the commit template
for this.  Further it has been standard operating procedure
for at least as long as I have been back that submitters
are infact recognized in commit messages.

You have, again, summarily dismissed valid feedback.

-- 
Rod Grimes                                                 rgrimes@freebsd.org