Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 May 2015 21:45:41 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Cy Schubert <cy@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r280849 - in head: contrib/ntp contrib/ntp/adjtimed contrib/ntp/arlib contrib/ntp/clockstuff contrib/ntp/conf contrib/ntp/html contrib/ntp/html/build contrib/ntp/html/drivers contrib/nt...
Message-ID:  <20150525194541.GB39108@ivaldir.etoilebsd.net>
In-Reply-To: <201503301330.t2UDUHpI094651@svn.freebsd.org>
References:  <201503301330.t2UDUHpI094651@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--lEGEL1/lMxI0MVQ2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 30, 2015 at 01:30:17PM +0000, Cy Schubert wrote:
> Author: cy
> Date: Mon Mar 30 13:30:15 2015
> New Revision: 280849
> URL: https://svnweb.freebsd.org/changeset/base/280849
>=20
> Log:
>   MFV ntp 4.2.8p1 (r258945, r275970, r276091, r276092, r276093, r278284)
>  =20
>   Thanks to roberto for providing pointers to wedge this into HEAD.
>  =20
>   Approved by:	roberto
>=20
Thanks for the update, but you have reintroduced overlinking of useless
libraries all over ntp.

for example with ntpdc:
The binary does not need at all to link with ncurses explicitly
The binary does not need to link with both libedit and readline (libedit is
enough and prefered)
The binary does not need to link to libmd as it does not use it.
The binary needs libcrypto but absolutly not to libssl

Also ntpdc does not build if WITHOUT_OPENSSL because in the config.h it is
hardcoded that it needs openssl, for example:
#define USE_OPENSSL_CRYPTO_RAND 1

Before the update, libmd was used for the digests functions. gGven now it is
hardcoded that openssl is required libmd should be replaced by libcrypto but
you should not have both.

I'm working on fixing the overlink, but given I know nothing about libntp's=
 code
I will let others have a look on what to do with the MK_OPENSSL.

Best regards,
Bapt

--lEGEL1/lMxI0MVQ2
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlVje+UACgkQ8kTtMUmk6ExeJwCfY+n2ZdEbLNhOPdodxWwQwb37
IlkAnRZ0/CI6KLSTCuD4kblcHHfs4UzG
=NyrN
-----END PGP SIGNATURE-----

--lEGEL1/lMxI0MVQ2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150525194541.GB39108>