From owner-svn-src-all@FreeBSD.ORG Mon May 25 19:45:47 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DD978FEA; Mon, 25 May 2015 19:45:46 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com [IPv6:2a00:1450:400c:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7037228B; Mon, 25 May 2015 19:45:46 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicmx19 with SMTP id mx19so47385510wic.0; Mon, 25 May 2015 12:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ktlb+k9g2kDGJYFcR42sifzr+3Gb2BO7KTTBpMRPuw8=; b=bSq5/mi/3t5brHk3L8fM3/fq8J6mReZgXVlTEwkJgDbFiwzWji1Nq3PrKvis745kPp iDKk+zUYGe2p/k9adlj1ms27SBoQqsub6Bo34f6Ybi/nf9H54Q8Flq1fHXTrDOXpl/Y6 xshpC5jjdHQ4PEYRCWJbSpqb1HZz5zOLZYXthnkDELSNf8JHcsNiQOz6Uspq5lPxSA7E SSuok43fTqxyf3xHaJx5K1VErlwmE9N5WvuWWOYhiSYOuQjvbBPZFL2NZaUrbS+boVtB i9VQWJlfEkqlXyLAkfFZNbC4yW6umqOP5+SAf3KOubh38XsLy7KyZ6pV78yZLODKTjWe sTOQ== X-Received: by 10.194.189.4 with SMTP id ge4mr23173398wjc.111.1432583145050; Mon, 25 May 2015 12:45:45 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id ex5sm13384770wib.2.2015.05.25.12.45.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 May 2015 12:45:43 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 25 May 2015 21:45:41 +0200 From: Baptiste Daroussin To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r280849 - in head: contrib/ntp contrib/ntp/adjtimed contrib/ntp/arlib contrib/ntp/clockstuff contrib/ntp/conf contrib/ntp/html contrib/ntp/html/build contrib/ntp/html/drivers contrib/nt... Message-ID: <20150525194541.GB39108@ivaldir.etoilebsd.net> References: <201503301330.t2UDUHpI094651@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lEGEL1/lMxI0MVQ2" Content-Disposition: inline In-Reply-To: <201503301330.t2UDUHpI094651@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 19:45:47 -0000 --lEGEL1/lMxI0MVQ2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 30, 2015 at 01:30:17PM +0000, Cy Schubert wrote: > Author: cy > Date: Mon Mar 30 13:30:15 2015 > New Revision: 280849 > URL: https://svnweb.freebsd.org/changeset/base/280849 >=20 > Log: > MFV ntp 4.2.8p1 (r258945, r275970, r276091, r276092, r276093, r278284) > =20 > Thanks to roberto for providing pointers to wedge this into HEAD. > =20 > Approved by: roberto >=20 Thanks for the update, but you have reintroduced overlinking of useless libraries all over ntp. for example with ntpdc: The binary does not need at all to link with ncurses explicitly The binary does not need to link with both libedit and readline (libedit is enough and prefered) The binary does not need to link to libmd as it does not use it. The binary needs libcrypto but absolutly not to libssl Also ntpdc does not build if WITHOUT_OPENSSL because in the config.h it is hardcoded that it needs openssl, for example: #define USE_OPENSSL_CRYPTO_RAND 1 Before the update, libmd was used for the digests functions. gGven now it is hardcoded that openssl is required libmd should be replaced by libcrypto but you should not have both. I'm working on fixing the overlink, but given I know nothing about libntp's= code I will let others have a look on what to do with the MK_OPENSSL. Best regards, Bapt --lEGEL1/lMxI0MVQ2 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlVje+UACgkQ8kTtMUmk6ExeJwCfY+n2ZdEbLNhOPdodxWwQwb37 IlkAnRZ0/CI6KLSTCuD4kblcHHfs4UzG =NyrN -----END PGP SIGNATURE----- --lEGEL1/lMxI0MVQ2--