From owner-freebsd-wireless@freebsd.org Sun Jul 3 20:16:45 2016 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 053C2B9071C for ; Sun, 3 Jul 2016 20:16:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D142924E7 for ; Sun, 3 Jul 2016 20:16:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u63KGi6h004446 for ; Sun, 3 Jul 2016 20:16:44 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 210799] if_bwi broken Date: Sun, 03 Jul 2016 20:16:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: josla972@student.liu.se X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jul 2016 20:16:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210799 Bug ID: 210799 Summary: if_bwi broken Product: Base System Version: 10.3-RELEASE Hardware: ppc OS: Any Status: New Severity: Affects Only Me Priority: --- Component: wireless Assignee: freebsd-wireless@FreeBSD.org Reporter: josla972@student.liu.se After I upgraded from FreeBSD 9.0 to 10.3-RELEASE on my Mac Mini G4, I found that "kldload if_bwi" would make the system unstable, and if I included it = to be loaded in loader.conf, I could not even boot. This used to work just fin= e. Digging through the commits the bwi folder of the git clone of freebsd, I f= ound the issue: commit ad311f67aaa6771c007f5046d032924146784a23 Author: mav Date: Tue Apr 21 11:27:50 2015 +0000 MFC r280347: Remove MAXBSIZE use from drivers where it has nothing to d= o. In some cases limits are just not needed, in others -- DFLTPHYS is the right constant to use instead. diff --git a/sys/dev/bwi/if_bwi.c b/sys/dev/bwi/if_bwi.c index 911e49e..6ce433c1 100644 --- a/sys/dev/bwi/if_bwi.c +++ b/sys/dev/bwi/if_bwi.c @@ -1915,7 +1915,7 @@ bwi_dma_alloc(struct bwi_softc *sc) lowaddr, /* lowaddr */ BUS_SPACE_MAXADDR, /* highaddr */ NULL, NULL, /* filter, filterar= g */ - MAXBSIZE, /* maxsize */ + BUS_SPACE_MAXSIZE, /* maxsize */ BUS_SPACE_UNRESTRICTED, /* nsegments */ BUS_SPACE_MAXSIZE_32BIT, /* maxsegsize */ BUS_DMA_ALLOCNOW, /* flags */ Reverting this commit made the system stable, if_bwi started working, and I could boot again. --=20 You are receiving this mail because: You are the assignee for the bug.=