From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Mar 6 22:35:48 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 54DAADBC for ; Fri, 6 Mar 2015 22:35:48 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1FE76DB1 for ; Fri, 6 Mar 2015 22:35:48 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t26MZleB016693 for ; Fri, 6 Mar 2015 22:35:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198375] [patch] mail/opensmtpd Add option to not modify mailer.conf Date: Fri, 06 Mar 2015 22:35:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: adamw@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ashish@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2015 22:35:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198375 Bug ID: 198375 Summary: [patch] mail/opensmtpd Add option to not modify mailer.conf Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ashish@FreeBSD.org Reporter: adamw@FreeBSD.org Flags: maintainer-feedback?(ashish@FreeBSD.org) Assignee: ashish@FreeBSD.org Keywords: patch Created attachment 153939 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153939&action=edit patch The OpenSMTPD port always modifies /etc/mail/mailer.conf. This makes installing it a destructive event---you cannot install it and tweak the configuration before making it live. To me this is a POLA violation, as other mail servers don't do that. The attached patch adds a new OPTION, and defaults it to on, to determine whether mailer.conf is written on installation. The end result is the same for binary package users. Also, the attached patch suggests a new COMMENT line... the current COMMENT line doesn't really say much and it violates rule #2 from https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-comment.html -- You are receiving this mail because: You are the assignee for the bug.