From nobody Sat Mar 7 07:51:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fSb7b68gYz6T33S for ; Sat, 07 Mar 2026 07:51:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fSb7b27cjz3d3V for ; Sat, 07 Mar 2026 07:51:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772869883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D+OUNyi++LWsQxoVgCs4K/JszyKbMM03aKRxqr6Km5g=; b=bwBqMvjNfqhNUECI8dtpTboxiDb2ROUcGG2QYVyh00XReOjFDiNT7MQTnfxjNiXRzqdiiZ CwypY1/YRwQr33EUNbeSdg+BxLvSnZIW/6balNDJOMGag4VQxj3JBw1bsgUAbsLwR/qvMq bMAGQpE3VTtNr68vJRCbWQh5gUfiefvt/ihejREoTFI0MB4OFtFbsAvTxC+mYysp9Tz8t2 btLF9EJTky99cmUt+zZh0tehWB+5m3psxZxU8vcywTgouqMkOAJRH7Gs+NVVmYoizPYdrN ihkTP3Gjr8tWgIYLVUNY/3FW8oCtUrFHNq/6NdrLRlyL201v/iiQINTKze/BLw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772869883; a=rsa-sha256; cv=none; b=MyEsFbVveyK2QEbH+/h5b533ugp0dCnCmtVHcsnVS4wQ4zxyok1QX+g0ofQnQodw66szJQ /Vtrvk5cd6CsPRJ03by76gpysP/xpdexO39fK0qBpQYwgLYs40zZ6H/Fr8UGytkfoxWXz9 lDskP6xD852OjOylxSlRTRSEalPSpmPu4aC3L/rLzlFrq2yrAurYOC+ODc7U8mntG3WzY5 aRIT+AFf1dxsZ3x8gd4qgSF+rk5b5TJc6cH8geG5daUqBO9B5KS/SF4+FXmeLib119n/fr MPkUlKcBGDmhOkFNrCjPJ3xcjy06gzZVCLU5KVqxIqGpMTiZ8rLEXJ3k6lsC4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772869883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D+OUNyi++LWsQxoVgCs4K/JszyKbMM03aKRxqr6Km5g=; b=Tjbu4gDGSJRj7N9fEJ2PDGdnW6tLznOv0A/jKqLjoOLp2m2Qzv+v1tcBJJDW3ZG0cq1w7e QGYb6PHC0X+7KivBYuxBVsnRk+5yibjlLQ3Hyeba9Nn7xuNk8SmBKj/iR3E1BT9ZkSdtqD hpoafvLSsboZ+S1otNzHPwryIyQfLotQbNQ7jiET0spQB/rpXcVXS/b7x9ntSluGCJvJbk +iHA18pPxQhM4SQC2PqMDSRdKMlylXP55w72La8/JusdP98zWoccm1u7jIGZAXZd7brzN6 dtQtimSu/RXajVJ/gyQ/MbW+nInBYPjp1GNTFuXg95T3AFboD8pY2ypLrfbJ1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fSb7b1ZwQz10nr for ; Sat, 07 Mar 2026 07:51:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22553 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 07 Mar 2026 07:51:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Jamie Landeg-Jones From: Warner Losh Subject: git: 9006a731bc95 - main - /bin/ps: Fix display of negative nice values on ARMv7/aarch64 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9006a731bc951c5b62efc4bf75a0c5b42586d279 Auto-Submitted: auto-generated Date: Sat, 07 Mar 2026 07:51:18 +0000 Message-Id: <69abd8f6.22553.76e52a6f@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=9006a731bc951c5b62efc4bf75a0c5b42586d279 commit 9006a731bc951c5b62efc4bf75a0c5b42586d279 Author: Jamie Landeg-Jones AuthorDate: 2026-03-07 01:18:20 +0000 Commit: Warner Losh CommitDate: 2026-03-07 07:51:14 +0000 /bin/ps: Fix display of negative nice values on ARMv7/aarch64 On Arm-based systems (and maybe others), 'char' defaults to unsigned, causing negative nice values to be displayed incorrectly (e.g., 246 instead of -10). Explicitly using 'signed char' ensures consistent behaviour across architectures. [ tested on RPI2 and generic aarch64 qemu install ] Before: # /usr/bin/nice --10 ps -l | awk '(NR == 1 || $(NF-1) == "ps")' UID PID PPID C PRI NI VSZ RSS MWCHAN STAT TT TIME COMMAND 0 23606 22800 2 -32 246 5400 2544 - R<+ 0 0:00.06 ps -l After: # /usr/bin/nice --10 ps -l | awk '(NR == 1 || $(NF-1) == "ps")' UID PID PPID C PRI NI VSZ RSS MWCHAN STAT TT TIME COMMAND 0 23614 22800 3 -32 -10 5400 2544 - R<+ 0 0:00.05 ps -l Signed-off-by: Jamie Landeg-Jones Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/2064 --- bin/ps/keyword.c | 2 +- bin/ps/print.c | 3 +++ bin/ps/ps.h | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/bin/ps/keyword.c b/bin/ps/keyword.c index 0562fd2e4f9d..d7790f9f8c48 100644 --- a/bin/ps/keyword.c +++ b/bin/ps/keyword.c @@ -133,7 +133,7 @@ static VAR keywords[] = { {"mwchan", {NULL}, "MWCHAN", "wait-channel", LJUST, mwchan, 0, UNSPEC, NULL}, {"ni", {"nice"}, NULL, NULL, 0, NULL, 0, UNSPEC, NULL}, - {"nice", {NULL}, "NI", "nice", 0, kvar, KOFF(ki_nice), CHAR, "d"}, + {"nice", {NULL}, "NI", "nice", 0, kvar, KOFF(ki_nice), SCHAR, "d"}, {"nivcsw", {NULL}, "NIVCSW", "involuntary-context-switches", USER, rvar, ROFF(ru_nivcsw), LONG, "ld"}, {"nlwp", {NULL}, "NLWP", "threads", 0, kvar, KOFF(ki_numthreads), diff --git a/bin/ps/print.c b/bin/ps/print.c index f59e843effc1..9705d0c07419 100644 --- a/bin/ps/print.c +++ b/bin/ps/print.c @@ -754,6 +754,9 @@ printval(void *bp, const VAR *v) case CHAR: (void)asprintf(&str, ofmt, *(char *)bp); break; + case SCHAR: + (void)asprintf(&str, ofmt, *(signed char *)bp); + break; case UCHAR: (void)asprintf(&str, ofmt, *(u_char *)bp); break; diff --git a/bin/ps/ps.h b/bin/ps/ps.h index 065a4c1f1c54..8352f3450f93 100644 --- a/bin/ps/ps.h +++ b/bin/ps/ps.h @@ -33,7 +33,7 @@ #define UNLIMITED 0 /* unlimited terminal width */ enum type { UNSPEC, /* For output routines that don't care and aliases. */ - CHAR, UCHAR, SHORT, USHORT, INT, UINT, LONG, ULONG, KPTR, PGTOK }; + CHAR, SCHAR, UCHAR, SHORT, USHORT, INT, UINT, LONG, ULONG, KPTR, PGTOK }; typedef struct kinfo_str { STAILQ_ENTRY(kinfo_str) ks_next;